Fix JS Paint in 98.js.org

1j01 · 1j01 · commit 04804396e187 · 2024-06-27T20:41:58.000-04:00
The fix 421fad7dc25c4d27caa46535a was incomplete and untested until now.
diff --git a/src/app.js b/src/app.js
@@ -658,7 +658,7 @@ function* traverse_menu(menu_items, menu_element) {
 		}
 		yield [menu_item, menu_item_element];
 		if (menu_item.submenu) {
-			yield* traverse_menu(menu_item.submenu, document.getElementById(menu_item_element.getAttribute("aria-controls")));
+			yield* traverse_menu(menu_item.submenu, menu_document.getElementById(menu_item_element.getAttribute("aria-controls")));
 		}
 		// if (menu_item.radioItems) {
 		// 	yield* traverse_menu(menu_item.radioItems, menu_element);
@@ -687,7 +687,7 @@ for (const [menu_item, menu_item_element] of traverse_menu(menus["E&xtras"], ext
 		`;
 	}
 }
-$("<style>").text(emoji_css).appendTo("head");
+$("<style>").text(emoji_css).appendTo(menu_document.head);
 
 // Electron menu integration
 if (window.is_electron_app) {

Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,7 @@ function* traverse_menu(menu_items, menu_element) {`
`658`	`658`	`}`
`659`	`659`	`yield [menu_item, menu_item_element];`
`660`	`660`	`if (menu_item.submenu) {`
`661`		`- yield* traverse_menu(menu_item.submenu, document.getElementById(menu_item_element.getAttribute("aria-controls")));`
	`661`	`+ yield* traverse_menu(menu_item.submenu, menu_document.getElementById(menu_item_element.getAttribute("aria-controls")));`
`662`	`662`	`}`
`663`	`663`	`// if (menu_item.radioItems) {`
`664`	`664`	`// yield* traverse_menu(menu_item.radioItems, menu_element);`
`@@ -687,7 +687,7 @@ for (const [menu_item, menu_item_element] of traverse_menu(menus["E&xtras"], ext`
`687`	`687`	`;
`688`	`688`	`}`
`689`	`689`	`}`
`690`		`-$("<style>").text(emoji_css).appendTo("head");`
	`690`	`+$("<style>").text(emoji_css).appendTo(menu_document.head);`
`691`	`691`
`692`	`692`	`// Electron menu integration`
`693`	`693`	`if (window.is_electron_app) {`