Skip to content

Commit 991b1cc

Browse files
committed
Combine code checking scripts into npm run lint
1 parent 82ebbcf commit 991b1cc

2 files changed

Lines changed: 5 additions & 8 deletions

File tree

README.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -342,11 +342,7 @@ Install [Node.js][] if you don't have it, then open up a command prompt / termin
342342

343343
### Testing
344344

345-
Run `npm run lint` to check for code problems.
346-
347-
Run `npm run spellcheck` to check for spelling errors. This may be included in the linting script in the future.
348-
349-
Run `npm run typecheck` to check for type errors. This may be included in the linting script in the future. Not much of the codebase is typechecked yet.
345+
Run `npm run lint` to check for spelling errors, type errors, code style issues, and other problems.
350346

351347
Run `npm test` to run browser-based tests with Cypress. (It's slow to start up and run tests, unfortunately.)
352348

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,10 @@
117117
"electron:package": "electron-forge package",
118118
"electron:make": "electron-forge make",
119119
"electron:publish": "electron-forge publish",
120-
"typecheck": "tsc --noEmit -p jsconfig.json",
121-
"spellcheck": "cspell-cli lint .",
122-
"lint": "eslint",
120+
"lint-cspell": "cspell-cli lint .",
121+
"lint-tsc": "tsc --noEmit --project jsconfig.json",
122+
"lint-eslint": "eslint",
123+
"lint": "npm-run-all --continue-on-error --serial lint-*",
123124
"build-css": "rtlcss styles/layout.css styles/layout.rtl.css && rtlcss lib/os-gui/build/layout.css lib/os-gui/build/layout.rtl.css && rtlcss lib/98.css/98.custom-build.css lib/98.css/98.custom-build.rtl.css",
124125
"watch-css": "onchange --initial --poll 100 \"styles/layout.css\" \"lib/os-gui/build/layout.css\" \"lib/98.css/98.custom-build.css\" -- npm run build-css",
125126
"update-localization": "node ./localization/preprocess.js",

0 commit comments

Comments
 (0)