New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Home Assistant MQTT room presence support (ESP32 only) #294

Merged
merged 2 commits into from Nov 2, 2018

Conversation

Projects
2 participants
@animavitis
Copy link
Contributor

animavitis commented Oct 30, 2018

#260 Added support for HASS room presence.

@1technophile 1technophile added this to the V0.9 milestone Oct 30, 2018

@1technophile
Copy link
Owner

1technophile left a comment

Thanks for this PR, could you add also the home assistant room presence macros to tests/test_config.h also?

@animavitis

This comment has been minimized.

Copy link
Contributor Author

animavitis commented Nov 2, 2018

@1technophile sorry for stupid question, but what do you mean by "home assistant room presence macros"??

@1technophile

This comment has been minimized.

Copy link
Owner

1technophile commented Nov 2, 2018

I thought you defined roomPresence into user_config.h and it is not the case. In this case there is nothing to do more.

Thanks for the PR :-)

@1technophile 1technophile merged commit f77df73 into 1technophile:master Nov 2, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@1technophile 1technophile added this to Done in V0.9 Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment