Add the getClientOriginalName method to the FileInterface #117

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@jubianchi

Related to #114.

I just added the getClientOriginalName to the FileInterface.
I have a doubt on what I did in the GaufretteFile.. don't know if it's OK... let me know if I have to change something or if I totally missed the point :)

@sheeep

This comment has been minimized.

Show comment
Hide comment
@sheeep

sheeep Jul 18, 2014

Contributor

Hej @jubianchi

As you've correctly stated, #114 showed that this is far from being correct; having method calls without the method signature in the interface. The problem is: adding getClientOriginalName to the interface does not particularly enhance the correctness. clientOriginalName should only exist on an UploadedFile.

My plan for version 2 is a bit different. IIRC we have this code smell, because of the Orphanage (storing files before actually uploading, (aka. store to the correct place) them). This will change, so we temporarily save the UploadedFiles instead of a Filesystem/Gaufrette file.

Would it be ok, if I postpone this issue until version 2 is out?

Contributor

sheeep commented Jul 18, 2014

Hej @jubianchi

As you've correctly stated, #114 showed that this is far from being correct; having method calls without the method signature in the interface. The problem is: adding getClientOriginalName to the interface does not particularly enhance the correctness. clientOriginalName should only exist on an UploadedFile.

My plan for version 2 is a bit different. IIRC we have this code smell, because of the Orphanage (storing files before actually uploading, (aka. store to the correct place) them). This will change, so we temporarily save the UploadedFiles instead of a Filesystem/Gaufrette file.

Would it be ok, if I postpone this issue until version 2 is out?

@jubianchi

This comment has been minimized.

Show comment
Hide comment
@jubianchi

jubianchi Jul 18, 2014

@sheeep no problem to postpone this issue, I'm fine with that if it leads to a better/clean solution ;)

@sheeep no problem to postpone this issue, I'm fine with that if it leads to a better/clean solution ;)

@sheeep sheeep self-assigned this Jul 18, 2014

@sheeep sheeep added this to the Version 2.0 milestone Jul 18, 2014

@bytehead bytehead removed this from the 2.0 milestone Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment