Expand search: text in description

[tarnung]

Continuation of the discussion in #504

Should descriptions only be searched when explicitly queried with a search term like desc: like for timestamps or should their text be a part of regular word search?

Should the raw description be used for search or should only certain parts ( as in header.get('description').filter(d=>d.get('type')==='text')) be used?

[munen]

Thanks for already tackling the next issue^^

Should descriptions only be searched when explicitly queried with a search term like desc: like for timestamps or should their text be a part of regular word search?

The former.

Should the raw description be used for search or should only certain parts ( as in header.get('description').filter(d=>d.get('type')==='text')) be used?

The latter.

[schoettl]

Should the raw description be used for search or should only certain parts ( as in header.get('description').filter(d=>d.get('type')==='text')) be used?

The latter.

Are you sure @munen? E.g. *bold* would not be found then – which is arguably OK.

But what is with this query:

desc:"two words"

when the actual text is two *words*?

IMO it would be best to match header.get('descriptionAsPlainText') or just header.get('rawDescription')... the first doesn't exist though.

[munen]

Are you sure @munen?

Apologies. I had some memory of rawDescription including all the other metadata (like
PROPERTIES and planning items) which is just a wrong memory:

With the current data we have, searching in rawDescription is likely the best. To get around the markup issue you mentioned, we could exclude the common markup (‘bold’, ‘/italic/’, ‘underlined’, ‘=verbatim=’ and ‘code’, ‘+strike-through+’.) in search.

Quick'n'dirty POC:

munen@lambda:~% node
> 'two *words*'.replace(/\*([\w]*)\*/, (match, p1, offset, string) => p1).match(/two words/)
[ 'two words', index: 0, input: 'two words', groups: undefined ]

Thank you for double checking on me, @schoettl!