Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linyuxin #1

Closed
wants to merge 15 commits into from
Closed

Linyuxin #1

wants to merge 15 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2020

mapbox版市级疫情数据展示

Copy link
Contributor

@yc111 yc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下几处需要讨论修改下

  1. 代码跟dev分支的main.js有冲突,mergemaster会影响master分支的稳定性,建议咱们提pr合并到dev,便于在dev分支处理冲突。以保证dev是最新的,master是最稳定的。
  2. src/components/LeafletMap.vue 中 line 9、 128、 213、238 尽量不要在页面直接使用axios,应在/arc/api目录下统一管理。
  3. 页面报了以下3类error共36个:
    Error: Style is not done loading
    Error: layers.500000.paint.fill-color[76]
    Error: Layer with id "420000" already exists on this map

@yc111 yc111 self-requested a review February 7, 2020 12:12
@ghost ghost closed this Feb 8, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant