Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

see details #4

Closed
wants to merge 4 commits into from

3 participants

@jameszhou

see details

@jamesaimonetti
Collaborator

I don't think cowboy is necessary to start in the whistle_apps startup. It is primarily used by Crossbar, Fax, and Media Manager, and should be started by those whapps when they start.

but if you don't start it,there will be error log after start whistle_app

@jamesaimonetti
Collaborator

This one is tricky. We need to build rabbitmq server before rabbitmq client, and lager before any of the 2600hz libs. The glob pattern will build things in somewhat alphabetical order, hence why we explicitly list the three at the top. I realize make emits a warning, but it is ignorable.

@k-anderson
Owner

Thanks! These requests should have been addressed by James, if not let us know.

@k-anderson k-anderson closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 15, 2012
  1. @jameszhou

    fix makefile bug

    jameszhou authored
  2. @jameszhou

    fix rebar compile bug

    jameszhou authored
  3. @jameszhou

    fix makefile bug

    jameszhou authored
Commits on Dec 16, 2012
  1. @jameszhou

    fix whistle_apps start bug

    jameszhou authored
    start cowboy
This page is out of date. Refresh to see the latest.
View
5 Makefile
@@ -2,10 +2,7 @@ ROOT = .
DIALYZER = dialyzer
REBAR = $(ROOT)/bin/rebar
-MAKEDIRS = lib/rabbitmq_server-2.8.6/Makefile \
- lib/rabbitmq_client-2.8.6/Makefile \
- lib/lager-1.0.0/Makefile \
- lib/*/Makefile \
+MAKEDIRS = lib/*/Makefile \
ecallmgr/Makefile \
whistle_apps/Makefile
View
1  lib/rabbitmq_client-2.8.6/common.mk
@@ -36,6 +36,7 @@ ifndef TMPDIR
TMPDIR := /tmp
endif
+ERL_LIBS=../
EBIN_DIR=ebin
BROKER_DIR=../rabbitmq_server-2.8.6
export INCLUDE_DIR=include
View
2  whistle_apps/apps/conference/rebar.config
@@ -2,4 +2,4 @@
,debug_info
]}. % uncomment to get debug messages, remove debug_info for production
{dialyzer_opts, [{warnings, [unmatched_returns, race_conditions, error_handling]}]}.
-{lib_dirs, ["../lib"]}.
+{lib_dirs, ["../../../lib","../../lib"]}.
View
1  whistle_apps/src/whistle_apps.erl
@@ -28,6 +28,7 @@ start_deps() ->
whistle_apps_deps:ensure(),
lager:start(),
+ application:start(cowboy),
case application:get_env(reloader) of
{ok, true} -> reloader:start();
Something went wrong with that request. Please try again.