Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors due to GDPR changes of GS. #1153

Closed
2Abendsegler opened this issue Dec 30, 2019 · 19 comments
Closed

Errors due to GDPR changes of GS. #1153

2Abendsegler opened this issue Dec 30, 2019 · 19 comments
Assignees
Milestone

Comments

@2Abendsegler
Copy link
Owner

@2Abendsegler 2Abendsegler commented Dec 30, 2019

grafik

In Cache Listings werden massenhaft GClh Fehler angezeigt. Die VIPs sind nicht vollständig, die Logs werden nicht durch GClh angezeigt, Favoriten % wird nicht angezeigt, obere Karte wird nicht angezeigt ... .
Gemäß Aussage eines Message Center Kontakts treten die Fehler unter Chrome auf.
Unter FF Android treten sie bei mir auch auf. Ich hab keinen Rechner zur Verfügung und mach mit meinem Smartphone rum.

@Ruko2010, @capoaira
Kann sich das vielleicht jemand von euch ansehen?

@2Abendsegler 2Abendsegler added the bug label Dec 30, 2019
@capoaira

This comment has been minimized.

Copy link
Contributor

@capoaira capoaira commented Dec 30, 2019

Bei mir treten sie auch in Chrome auf, aber auch in FF. IE kann ich nicht testen.
Scheinbar tritt der Bug erst seit heute Abend auf, denn heute Nachmittag wurden mir die Fehler noch nicht angezeigt.

@diundbi

This comment has been minimized.

Copy link

@diundbi diundbi commented Dec 30, 2019

Diese Probleme tauchten nach einem kurzen Serverausfall der geocaching.com Seite auf:
Logs werden im Listing nicht automatisch dargestellt,
keine Logs von Freunden,
die kleine untere Übersichtskarte fehlt.
Aufgetreten bei zwei Rechner unter Chrome

@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Dec 30, 2019

Serverausfall der geocaching.com Seite

Ah, ok, der war bei gc. Vielleicht sollten wir noch etwas warten und hoffen. 😊

@have-moicy

This comment has been minimized.

Copy link

@have-moicy have-moicy commented Jan 1, 2020

Problem seems to be associated with a change in chrome cookie policy:

A cookie associated with a cross-site resource at https://www.google.com/ was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.

@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Jan 1, 2020

@have-moicy
Thanks for this information. We will look at this.
But I am afraid that the problems are due to the changes of Groundspeack on the geocaching websites. It affects all browsers and even without scripts the geocaching websites do not all work correctly.

@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Jan 1, 2020

A solution for all the problems seems to be a blocking of address "cookiebot.com". The Addon uBlock Origin 1.24.2 can do that for example.
https://geoclub.de/forum/viewtopic.php?f=117&t=81216&start=30#p1303961

@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Jan 1, 2020

@Ruko2010, @capoaira und andere

Hab die Info in den Foren (geoclub.de/forum, forums.geocaching.com, swissgeocacheforum.ch, geocaching.cz) getriggert, siehe unten.

Jetzt können wir uns überlegen, ob wir vielleicht selbst noch etwas im GClh tun können weil die Info sicherlich nicht jeden erreicht und einige auch damit überfordert sein könnten. Wenn wir die Adresse im GClh blockieren könnten, wäre das sicherlich keine schlechte Idee. Ich habe aber im Moment keine Ahnung wie wir das machen können. Habt ihr Ideen, Vorschläge?


Eine mögliche Lösung, der seit dem 31.12.2019 bestehenden Probleme mit Scripten, ist wohl die Blockierung der Adresse "cookiebot.com".
Arnos hat hier beschrieben wie man dazu vorgehen kann.
Frohe Neues Jahr.
Frank
PS: Das gilt für viele Scripte, so auch für GC Tour und Geocaching Map Enhancements.

@Ruko2010

This comment has been minimized.

Copy link
Collaborator

@Ruko2010 Ruko2010 commented Jan 1, 2020

I have the same problem in Chrome and FF. I think it has something to do with the changes Groundspeak made to the cookie guidelines. Since the server breakdown I have to accept the cookie policy. this is new.

@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Jan 1, 2020

Moin, kurz mal überschnitten. :)
Du hast recht.

@Ruko2010

This comment has been minimized.

Copy link
Collaborator

@Ruko2010 Ruko2010 commented Jan 1, 2020

Ich schau es mir gerade näher an. Mal gucken ob wir was machen können. @2Abendsegler vielleicht finden ja GCTour oder andere Scripte vorher eine Lösung 😉.

@PontiacCZ

This comment has been minimized.

Copy link

@PontiacCZ PontiacCZ commented Jan 1, 2020

I restored the GClh II behavior by updating my filter in uBlock origin. Here's how: settings of uBlock origin -> "My filters" tab -> just enter "cookiebot.com" on a new line and hit "Apply changes". Refresh GC.com pages and there you go.

I consider this a temporary solution, majority of people sure won't be able to achieve this...

@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Jan 1, 2020

Hi PontiacCZ,

your describtion is correct. That is one way to solve the problems. If you have another ad blocker, it can probably do that too.

I consider this a temporary solution, majority of people sure won't be able to achieve this...

Yes, that is our opinion also.

But the topic is problematic and complex. GS tries to transpose the EU General Data Protection Regulation and something comparable from the USA with cookiebot. That's actually a good thing. However, cookiebot apparently use mechanisms that interfere with the execution of scripts. I am not yet sure whether we should attack here ourselves with the GClh. We would probably take some responsibility for this topic and I don't know how to explain it to our users.

If we find a solution to deactivate cookiebot itself, we will have to consult if we really want to implement it.

Actually it should be a topic for GS and cookiebot to implement the whole thing so that it also works with scripts. GS pays for the use of cookiebot.

@Ruko2010

This comment has been minimized.

Copy link
Collaborator

@Ruko2010 Ruko2010 commented Jan 2, 2020

I think disabling Cookiebot (IF we find a way to do this) is not the right approach.
We should find out why it is not working with cookiebot and find a solution to work in coexistens with cookiebot.
But we should wait for some days, if GC make more changes.

@Chrono81

This comment has been minimized.

Copy link

@Chrono81 Chrono81 commented Jan 3, 2020

Hello !
I am from France and I use Firefox 71.0 (64 bits) with TamperMonkey 4.10.6105 on a Windows 10 computer.
Before I read your temporary workaround (blocking cookiebot.com) that works well I found another way to work anyway.
It is certainly not an effective and lasting solution but it can possibly help you.
The GC Little Helper II script works fully if you deactivate TamperMonkey (left click on TM Icon et left click on Activated) then refresh the web page and finally reactivate TamperMonkey (same way as before).
You have to do it on every page but it works !
As you already know this is probably due to the new way used by Groundspeak to display geocaching data.
Thank you for your understanding and your work ! ! !

@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Jan 3, 2020

Hello,
thanks for this great information! I tried it and it works as described. :)
I think you are the guy from the french forum, who translated some things from the new start of the GClh for the french forum, years ago. Thanks for that too. :)

When Tampermonkey is reactivated, the page is automatically redisplayed by Tampermonkey, without reloading. The GClh can therefore work with the pages, but apparently not simultaneously as the changes of GS around cookiebot. Or maybe not before the page is fully loaded. Our errors always seem to have something to do with unsafeWindow. In my understanding, these are queries to the GS resources on the loaded page. A solution could be, to wait until the necessary things are loaded, whatever these things are.
I tested with https://coord.info/GC3HA0P

(Off-Topic: France GClh community consists of about 25 users. Maybe that interests one or the other. That only because I just looked at the current numbers.)

@PontiacCZ

This comment has been minimized.

Copy link

@PontiacCZ PontiacCZ commented Jan 4, 2020

Hint was affected as well by the recent HQ change and will not decode correctly.

For instance https://coord.info/GC4YJ68

@Vylda

This comment has been minimized.

Copy link

@Vylda Vylda commented Jan 4, 2020

@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Jan 4, 2020

I have already seen it.
It's annoying, sorry.
I am working on it.

@2Abendsegler 2Abendsegler self-assigned this Jan 4, 2020
@2Abendsegler

This comment has been minimized.

Copy link
Owner Author

@2Abendsegler 2Abendsegler commented Jan 4, 2020

To do:

  • Show favorite percentage in cache listing run into error because of GSs GDPR changes.
  • Build map overview in cache listing run into error because of GSs GDPR changes.
  • Activate fancybox in cache listing run into error because of GSs GDPR changes.
  • Decrypt hints in cache listing run into error because of GSs GDPR changes.
  • Replace Log-Loading function in cache listing run into error because of GSs GDPR changes.
  • Show thumbnails in cache listing run into ReferenceError because of GSs GDPR changes.
  • Hide hints in cache listing behind a link with show/hide do not decrypt because of GSs GDPR changes.
  • Improve print page cache listing with hide disclaimer, decrypt hints, show other coord formats and hide side rights does not run.
  • Simplification of own GDPR coding.
2Abendsegler added a commit that referenced this issue Jan 4, 2020
Hide hints in cache listing behind a link with show/hide do not decrypt.
Improve print page cache listing with hide disclaimer, decrypt hints, show other coord formats and hide side rights does not run.
2Abendsegler added a commit that referenced this issue Jan 4, 2020
Cache Listing with many errors. #1153
2Abendsegler added a commit that referenced this issue Jan 4, 2020
Show favorite percentage in cache listing run into error because of GSs GDPR changes.
2Abendsegler added a commit that referenced this issue Jan 4, 2020
Cache Listing with many errors. #1153
2Abendsegler added a commit that referenced this issue Jan 4, 2020
Build map overview in cache listing run into error because of GSs GDPR changes.
2Abendsegler added a commit that referenced this issue Jan 4, 2020
Cache Listing with many errors. #1153
2Abendsegler added a commit that referenced this issue Jan 4, 2020
Activate fancybox in cache listing run into error because of GSs GDPR changes.
2Abendsegler added a commit that referenced this issue Jan 4, 2020
Cache Listing with many errors. #1153
2Abendsegler added a commit that referenced this issue Jan 5, 2020
2Abendsegler added a commit that referenced this issue Jan 5, 2020
Cache Listing with many errors. #1153
@2Abendsegler 2Abendsegler added this to the v0.10.2 milestone Jan 5, 2020
@2Abendsegler 2Abendsegler changed the title Cache Listing with many errors. Errors due to GDPR changes of GS. Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.