Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Cachegrind start/stop instrumentation requests #1

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Sep 11, 2023

@nnethercote is now in the process of adding client requests to Cachegrind. This PR exposes these requests from crabgrind.

Cachegrind normally uses the cg_ prefix, but I noticed that in crabgrind it's already "reserved" by Callgrind (which usually uses cl_. So I used cag_ in this PR to differentiate Callgrind and Cachegrind.

lib.rs Outdated Show resolved Hide resolved
lib.rs Outdated Show resolved Hide resolved
@2dav
Copy link
Owner

2dav commented Sep 12, 2023

Thank you for pointing this out, i think it's better to stick to "conventional" two-letter tool prefixes to avoid confusion, so :

  • vg valgrind the app
  • cl callgrind
  • cg cachegrind
  • hg helgrind
  • mc memcheck
  • ms massif
    there is now a develop branch with fixes. Could you change your PR accordingly?

@Kobzol
Copy link
Contributor Author

Kobzol commented Sep 12, 2023

Do you want me to change the base of this PR to develop or just rebase it on top of develop for now and then after it gets merged, rebased it again on top of main?

@2dav
Copy link
Owner

2dav commented Sep 12, 2023

Change the prefix from cag_ to cg_ and the base to 'develop', i believe.

@Kobzol Kobzol changed the base branch from main to develop September 12, 2023 17:42
@Kobzol
Copy link
Contributor Author

Kobzol commented Sep 12, 2023

Ok, done :)

@2dav 2dav merged commit 24bc9c5 into 2dav:develop Sep 12, 2023
@2dav
Copy link
Owner

2dav commented Sep 15, 2023

Thank you!
There is a missing link for Cachegrind requests doc, @Kobzol mind if i create an issue about this and assign it to you?

@Kobzol
Copy link
Contributor Author

Kobzol commented Sep 15, 2023

Sure, go ahead :)
https://valgrind.org/docs/manual/cg-manual.html it should appear here (probably once the next version of Valgrind is released).

@2dav 2dav linked an issue Sep 16, 2023 that may be closed by this pull request
@Kobzol Kobzol deleted the cachegrind branch September 23, 2023 17:54
@2dav
Copy link
Owner

2dav commented Nov 1, 2023

available in crabgrind 0.1.10, requires Valgrind 3.22 to build.

@Kobzol
Copy link
Contributor Author

Kobzol commented Nov 1, 2023

Thanks for updating the docs!

2dav added a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants