Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis Timeouts #1145

Closed
RichJeanes opened this issue May 26, 2015 · 13 comments
Closed

Travis Timeouts #1145

RichJeanes opened this issue May 26, 2015 · 13 comments
Labels
enhancement Issue/PR contains enhancements to the overall code of the site.

Comments

@RichJeanes
Copy link
Member

I think we need to do some reworking on the link checking. We've gotten to the point that we have so many links that they can't all be reliably checked within the Travis timeout window and I don't think sticking travis_wait on it is a good idea (though I think it's perfectly fine on bundle install).

Is checking all of them every time necessary? Is there a way to check just newly added links? Maybe we could periodically run a script (manually?) to check all if necessary?

@mxxcon
Copy link
Contributor

mxxcon commented May 26, 2015

Yes, it would be best to check just the affected URL(s).
Also does our https://github.com/jdavis/twofactorauth/blob/master/Gemfile.lock need to be that big? I imagine quiet a lot of Travis' time is spent installing those gems. Can we decrease their number or be less strict about versions just in case they are already installed on build nodes?(unless build nodes always start empty?)

@Carlgo11
Copy link
Member

Well that would be rather difficult to setup wouldn't it? I mean there's no way for the script to see what's changed.

And while we're on the topic of html-proofer, I'm thinking we need a way to check if the http links are available as https as well.

@RichJeanes
Copy link
Member Author

It can't use any diff info from GitHub?

Didn't someone experiment with HTTPS checks? (@jdavis maybe?)

@mxxcon
Copy link
Contributor

mxxcon commented May 26, 2015

How would you automate http vs https check and know if https site is the same as http?
Does any of this help us? http://docs.travis-ci.com/user/speeding-up-the-build/

@jamcat22
Copy link
Member

OOOOOOOOOOOOO!!!!!!!!!!!!!
What if we cache our dependencies?!?!?!?!?!?!?!
Since we just changed to the container-based architecture, this is now possible for open-source projects like us. (YAY!)

I feel like being enthusiastic today!!! 😄
Here's the doc on caching.
Here's the doc on container-based builds.

@jamcat22 jamcat22 added the enhancement Issue/PR contains enhancements to the overall code of the site. label Jul 22, 2015
@mxxcon
Copy link
Contributor

mxxcon commented Jul 22, 2015

@jamcat22 It's already in our .travis.yml

@jamcat22
Copy link
Member

jamcat22 commented Jul 22, 2015 via email

@mxxcon
Copy link
Contributor

mxxcon commented Jul 22, 2015

I added cache line when I added #1237.

@jamcat22
Copy link
Member

facepalm

@Carlgo11
Copy link
Member

And from what I can tell it isn't working atm

@jamcat22
Copy link
Member

Wait, don't we overwrite the install step?

@jamcat22
Copy link
Member

Do we have to use this to cache?

@jamcat22
Copy link
Member

With fbd5045 and #1312, this issue has been resolved.

Discussion on reimplementing html-proofer or a similar solution should be directed to #1265.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR contains enhancements to the overall code of the site.
Projects
None yet
Development

No branches or pull requests

4 participants