Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [weltsparen.de] SMS available and new logo #7561

Closed
2 tasks done
BaumiCoder opened this issue May 1, 2023 · 2 comments
Closed
2 tasks done

Update [weltsparen.de] SMS available and new logo #7561

BaumiCoder opened this issue May 1, 2023 · 2 comments
Labels
update site Issue/PR updates information about a site in the repo.

Comments

@BaumiCoder
Copy link
Contributor

BaumiCoder commented May 1, 2023

Site name

Weltsparen

Site URL

https://www.weltsparen.de/

Update reason

It now supports 2FA., Its logo has changed.

Additional information

  1. It now supports SMS. They call it "mTan" You don't need it for login, but for action like investing or to transfer money back to your bank account (links go to the german webhelp). Is that a restriction, which should be metioned in the "notes" field?
  2. The logo is now blue instead of orange. (Where are you getting the new logo without getting copyright problem?)

If someone can answer my question to the changes, I maybe will create a pull request on my own.

Issue Eligibility

  • The issue I'm creating is not a duplicate of an existing issue.
  • The issue I'm creating is not a duplicate of an existing pull request
@BaumiCoder BaumiCoder added the update site Issue/PR updates information about a site in the repo. label May 1, 2023
@BaumiCoder BaumiCoder changed the title Update [weltsparen.de] SMS available Update [weltsparen.de] SMS available and new logo May 1, 2023
@hkamran80
Copy link
Member

The way you described mTan, it's not two-factor authentication. It's authorization.

We get the logo from the website that is being added.

@BaumiCoder
Copy link
Contributor Author

Thank you for your fast answer.
I already supposed that this isn't a full authentication, but I wasn't sure how to name it. Now I got it.
I will update the logo and create an pull request.

@Carlgo11 Carlgo11 closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update site Issue/PR updates information about a site in the repo.
Projects
None yet
Development

No branches or pull requests

3 participants