New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a column for account recovery documentation #1348

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@runasand
Copy link

runasand commented Oct 3, 2015

Two-factor authentication is great until you lose the device. I wanted to help users get through the recovery process faster by specifically linking to the recovery documentation for the different services.

@mxxcon

This comment has been minimized.

Copy link
Member

mxxcon commented Oct 4, 2015

I can't tell from the code what it'll look like. Is it another checkmark?
Also do you think users would come to this site to look for a way how to recover their account?
It's a useful information, but I'm not sure users will refer to this site when they lose their phone..I just don't have a sense this is the type of user-workflow we have(not that I know what kind of flow we do have 😄)

@Carlgo11 Carlgo11 added the enhancement label Oct 4, 2015

@runasand

This comment has been minimized.

Copy link

runasand commented Oct 4, 2015

A new column is added on the right and the icon used is the same as for "Docs."

I think the same users who use the site now would use the site to find account recovery information. It seemed silly to create a new site just for that purpose, when twofactorauth.org is already a well-known page. I know I, personally, would use it if I ever lost my phone and had to go through the process for all the services I use.

@gcochard

This comment has been minimized.

Copy link

gcochard commented Oct 4, 2015

This is really useful. Would have saved me hours when getting a replacement phone. If someone comes to the site to learn how to add 2fa, they will know where to go when (not if) they need to recover. 👍 👏

@thorsheim

This comment has been minimized.

Copy link

thorsheim commented Oct 4, 2015

I doubt normal users will visit this site to find links to relevant account recovery docs, but for anyone developing or comparing services, this would be a great addition to the site. Also for all of us who nags service providers to improve their security, this addition will also be useful.

@Carlgo11

This comment has been minimized.

Copy link
Member

Carlgo11 commented Oct 4, 2015

We (the collaborators) will discuss whether or not to add this, but right now we're focusing on updating the site.

@Carlgo11 Carlgo11 added pending and removed pending labels Oct 4, 2015

@Carlgo11

This comment has been minimized.

Copy link
Member

Carlgo11 commented Oct 13, 2015

Hi again Runa,
thank you for your patience and dedication towards making the site better.

We've now discussed this and come to the conclusion that this wouldn't look good for mobile users.
The current layout is a mess for mobile users and this would unfortunately make it look worse for them.

While we all think the idea behind your PR is a great idea we'll have to pass at this time.
I apologize for not being able to merge this after all the work you've done.

//Carl ⛄️


P.S. I like your name. It's very old school Nordic 😉

@Carlgo11 Carlgo11 closed this Oct 13, 2015

@Carlgo11 Carlgo11 removed the vote label Oct 13, 2015

@jamcat22

This comment has been minimized.

Copy link
Member

jamcat22 commented Oct 13, 2015

@Carlgo11 I think we should merge it, because we would need the extra column to determine how to make responsive tables work.

@Carlgo11

This comment has been minimized.

Copy link
Member

Carlgo11 commented Oct 13, 2015

What, you said you agreed with Rich yesterday o.o

@jamcat22

This comment has been minimized.

Copy link
Member

jamcat22 commented Oct 13, 2015

I said "I agree with Rich. I love the idea, but we'll need to fix responsive tables if we add it."
I meant we should add it, and then fix responsive tables.

@Carlgo11 Carlgo11 reopened this Oct 13, 2015

@RichJeanes

This comment has been minimized.

Copy link
Member

RichJeanes commented Oct 13, 2015

Also, to be clear and not give the wrong impression to the public community, I said I really like the idea, but think the site is too cumbersome on mobile to be adding more to it. If we improve the mobile performance of the site (and other usability improvements along the way would not be a bad thing), I would love to see this feature.

@psgs psgs added this to the Non-Tabular Design milestone Oct 14, 2015

@psgs psgs referenced this pull request Oct 14, 2015

Closed

Alternate Design and Layout #1368

@jamcat22

This comment has been minimized.

Copy link
Member

jamcat22 commented Jan 10, 2016

Hello @runasand!

We're in the process of redesigning the overall look of the site (currently the alternate-layout branch), so I'm sorry that there hasn't been any activity on this PR in awhile.
With the new design, we should be able to include account recovery documentation without it being cumbersome on mobile device layouts.
There's still a bit of debate on whether or not we should add this, but if we choose to, it could take anywhere from a couple weeks to a month.

Thanks!

@psgs psgs added the notable label Jun 26, 2016

@Carlgo11 Carlgo11 removed the notable label Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment