Add UK Companies House #2199

Merged
merged 4 commits into from Jan 11, 2017

Projects

None yet

4 participants

@rubenarakelyan
Contributor

No description provided.

@Carlgo11
Member
Carlgo11 commented Jan 8, 2017

Does this login page differ from any other gov.uk login page or can the same credentials be used for multiple ministries?
Might be a stupid question but I just want to make sure the addition is relevant.

@psgs
Member
psgs commented Jan 9, 2017

Since this website forms a part of the overall gov.uk domain, this website might also work better as part of a more general entry for twofactorauth.org.

@Carlgo11
Member
Carlgo11 commented Jan 9, 2017

@psgs it depends on how independent the different subdomains are but that was my first instinct as well.

@rubenarakelyan
Contributor

Companies House logins are separate from other GOV.UK sites, which use either Government Gateway or GOV.UK Verify. Not all of them support 2FA yet either.

@Carlgo11
Member

I compressed the logo by 64%.
When pushing to the right branch I used the latest history of the main repo causing GitHub to think that all commits committed since the original's history parted with the main repo was commits that should be listed here.
To fix that massive log of commits in this PR I reset to the main repo's history and then cherry-picked the real commits of this PR. That way this PR is up to date with our master branch. Does does however mean that the time line of the commits are a bit wacky. Sorry about that! 😞

@Carlgo11 Carlgo11 merged commit 151385e into 2factorauth:master Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment