Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Australian Universities #7684

Merged
merged 25 commits into from Jul 25, 2023
Merged

Add Australian Universities #7684

merged 25 commits into from Jul 25, 2023

Conversation

AdamXweb
Copy link
Contributor

Have added a few more Australian universities to the list including:

  • Monash
  • La Trobe
  • UTS
  • UNSW
  • University of Sydney
  • University of Queensland
  • Deakin
  • Swinburne

@hkamran80 hkamran80 added add site Issue/PR adds a site to the repo. multiple sites Issue/PR includes multiple sites. labels Jul 22, 2023
hkamran80
hkamran80 requested changes Jul 22, 2023
View reviewed changes
Copy link
Member

@hkamran80 hkamran80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format all your JSON files in accordance with our .editorconfig

entries/d/deakin.edu.au.json Show resolved Hide resolved
entries/d/deakin.edu.au.json Outdated Show resolved Hide resolved
entries/d/deakin.edu.au.json Show resolved Hide resolved
entries/l/latrobe.edu.au.json Show resolved Hide resolved
entries/s/swinburne.edu.au.json Show resolved Hide resolved
img/s/sydney.edu.au.svg Outdated Show resolved Hide resolved
img/u/unimelb.edu.au.svg Outdated Show resolved Hide resolved
img/u/unsw.edu.au.png Outdated Show resolved Hide resolved
img/u/uq.edu.au.svg Outdated Show resolved Hide resolved
img/u/uts.edu.au.svg Outdated Show resolved Hide resolved
AdamXweb and others added 2 commits July 23, 2023 19:50
@AdamXweb @hkamran80
Update entries/u/uts.edu.au.json
f4347c3 
Co-authored-by: H. Kamran <hkamran@hkamran.com>
Signed-off-by: Adam Kostarelas <6800453+AdamXweb@users.noreply.github.com>
@AdamXweb @hkamran80
Apply suggestions from code review
f609524 
Co-authored-by: H. Kamran <hkamran@hkamran.com>
Signed-off-by: Adam Kostarelas <6800453+AdamXweb@users.noreply.github.com>
@AdamXweb
Copy link
Contributor Author

Please format all your JSON files in accordance with our .editorconfig

Done according to your suggestions. As a new contributor, it was not clear in the CONTRIBUTING.md as part of the process to set up. Have added to my workflow for future contributions

AdamXweb and others added 4 commits July 23, 2023 20:01
@AdamXweb
Update unsw image
ebe7609
@AdamXweb @hkamran80
Update img/s/sydney.edu.au.svg
866d1da 
As per suggestion

Co-authored-by: H. Kamran <hkamran@hkamran.com>
Signed-off-by: Adam Kostarelas <6800453+AdamXweb@users.noreply.github.com>
@AdamXweb @hkamran80
Update img/u/uq.edu.au.svg
778a3cb 
As per suggestion

Co-authored-by: H. Kamran <hkamran@hkamran.com>
Signed-off-by: Adam Kostarelas <6800453+AdamXweb@users.noreply.github.com>
@AdamXweb @hkamran80
Update img/u/uts.edu.au.svg
75f48d2 
As per suggestion

Co-authored-by: H. Kamran <hkamran@hkamran.com>
Signed-off-by: Adam Kostarelas <6800453+AdamXweb@users.noreply.github.com>
hkamran80
hkamran80 requested changes Jul 23, 2023
View reviewed changes
img/s/sydney.edu.au.svg Outdated Show resolved Hide resolved
img/u/unsw.edu.au.png Outdated Show resolved Hide resolved
AdamXweb and others added 3 commits July 24, 2023 11:12
@AdamXweb @hkamran80
Update img/s/sydney.edu.au.svg
60c41a0 
As per suggestion

Co-authored-by: H. Kamran <hkamran@hkamran.com>
Signed-off-by: Adam Kostarelas <6800453+AdamXweb@users.noreply.github.com>
@AdamXweb
Update unsw image with transparency
8c55add
@AdamXweb
Update images to match SVG lint
1c5afde
hkamran80
hkamran80 requested changes Jul 24, 2023
View reviewed changes
img/u/unimelb.edu.au.svg Outdated Show resolved Hide resolved
@AdamXweb @hkamran80
Update img/u/unimelb.edu.au.svg
e390724 
Co-authored-by: H. Kamran <hkamran@hkamran.com>
Signed-off-by: Adam Kostarelas <6800453+AdamXweb@users.noreply.github.com>
@AdamXweb
Copy link
Contributor Author

@hkamran80 Thanks for assisting with the pull request.
Will take on the suggestions for further contributions

@AdamXweb AdamXweb requested a review from hkamran80 July 24, 2023 04:50
hkamran80
hkamran80 requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@hkamran80 hkamran80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the warnings from our SVG lint test, I recommend changing Deakin, Latrobe, Monash, Swinburne, and Sydney's SVGs to PNGs.

@AdamXweb
Copy link
Contributor Author

Because of the warnings from our SVG lint test, I recommend changing Deakin, Latrobe, Monash, Swinburne, and Sydney's SVGs to PNGs.

Resized SVG, to remove warnings, and replaced ones that couldn't compress < 5120 bytes with PNGs

hkamran80
hkamran80 requested changes Jul 25, 2023
View reviewed changes
img/s/swinburne.edu.au.svg Outdated Show resolved Hide resolved
img/d/deakin.edu.au.svg Outdated Show resolved Hide resolved
img/d/deakin.edu.au.png Outdated Show resolved Hide resolved
img/u/uq.edu.au.png Outdated Show resolved Hide resolved
@hkamran80 hkamran80 merged commit 9ddea74 into 2factorauth:master Jul 25, 2023
3 checks passed
@hkamran80
Copy link
Member

Thank you! Your contribution will be visible in around 10 minutes, although it may take longer due to server and browser caches.

@AdamXweb
Copy link
Contributor Author

Thanks for your recommendations getting this PR to standard!

@hkamran80
Copy link
Member

Of course! I'm happy to have helped!

@AdamXweb
Copy link
Contributor Author

Aside from svgo or the web version SVGOMG, are there any other tools you'd recommend to remove unnecessary attributes from a SVG?

@hkamran80
Copy link
Member

hkamran80 commented Jul 26, 2023 •
edited

Our SVG lint test checks for the main ones. If you look at the source code, you should be able to identify some attributes that you don't need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkamran80 hkamran80 hkamran80 approved these changes

Assignees
No one assigned
Labels
add site Issue/PR adds a site to the repo. multiple sites Issue/PR includes multiple sites.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AdamXweb @hkamran80