Location returns wrong coordinates when apps screen slides up due to some input getting focus

[NickAb]

Coordinates returned by location command and used by click command are incorrect when apps screen slid up due to some input being focused, e.g. AutoSuggestBox, which leads to driver tapping incorrect screen point.

See AutoSuggestSample.cs. Replacing temporary execute script solution with suggest.Click() in test case will result in incorrect tap.

Possible solution: use GetClickablePoint for all elements that support it instead of current screen point calculation algorithm.

Simple replacement of location algorithm with GetClickablePoint resulted in test_automation_scroll failing, needs further investigation.

[NickAb]

Turns out that Frame passed to AutomationServer.Instance.InitializeAndStart not actual a root elements as whole application is wrapped into ScrollViewer that allows system to scroll application top to make place for on-screen keyborad, etc. This was causing the incorrect location being returned in case of on-screen keyboard or other system windows scrolling application view to top.

This can be fixed by something like

public Automator(UIElement visualRoot)
        {
            var root = visualRoot;

            while (true)
            {
                var parent = VisualTreeHelper.GetParent(root) as UIElement;
                if (parent == null)
                {
                    break;
                }

                root = parent;
            }

            this.VisualRoot = root;
            this.WebElements = new AutomatorElements();
        }

This will get rid of need to use GetClickablePoint and Actions to click to suggests.
Still needs research on possibility of replcaing custom location getter with GetClickablePoint.