Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image configuration #3

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Refactor image configuration #3

merged 6 commits into from
Jul 26, 2022

Conversation

sgibson91
Copy link
Contributor

No description provided.

@github-actions
Copy link

Binder 👈 Test this PR on Binder

@sgibson91
Copy link
Contributor Author

See 2i2c-org/infrastructure#1444 (comment) for current status of this PR

Copy link

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgibson91, I believe what's missing might be missing are the packages here:

https://github.com/jupyterhub/jupyter-remote-desktop-proxy/blob/7d9b2810669e22b5ecdcfee8d8f531c3da0ab8a9/Dockerfile#L6-L14

They are installed in the jmte hub image and the utoronto-image which also has a working desktop install.

@sgibson91
Copy link
Contributor Author

Woohoo, that worked! Thank you @GeorgianaElena! ❤️

@sgibson91 sgibson91 marked this pull request as ready for review July 26, 2022 10:26
@sgibson91 sgibson91 merged commit 4dfbdf3 into main Jul 26, 2022
@sgibson91 sgibson91 deleted the refactor branch July 26, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants