Skip to content

tf: Allow omitting optional fields in node definitions - #2664

Merged
yuvipanda merged 3 commits into
2i2c-org:masterfrom
yuvipanda:optional-tf
Jun 19, 2023
Merged

yuvipanda merged 3 commits into
2i2c-org:masterfrom
yuvipanda:optional-tf

Conversation

@yuvipanda

Copy link
Copy Markdown
Member

optional is a newish feature of Terraform that lets us omit certain fields from node definitions. This makes node definitions much easier to read, and stops requiring us to change all .tfvar files each time we add another way a nodepool can be customized.

`optional` is a newish feature of Terraform that lets us
omit certain fields from node definitions. This makes node
definitions much easier to read, and stops requiring us to change
*all* .tfvar files each time we add another way a nodepool
can be customized.
@yuvipanda
yuvipanda requested a review from a team as a code owner June 15, 2023 18:43

@consideRatio consideRatio left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is trailing commas allowed? Otherwise i think there are some errors related to having trailing commas introduced.

Thanks for helping us catch up with modern tf practices!!

/ from mobile

@yuvipanda

Copy link
Copy Markdown
Member Author

@consideRatio looks like the terraform autoformatter was not autoformatting tfvars files. I've fixed that now, so these should all work now I think.

@consideRatio consideRatio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Looks great and nice work on establishing the autoformatting for terraform files!

@yuvipanda
yuvipanda merged commit 02c2435 into 2i2c-org:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants