tf: Allow omitting optional fields in node definitions #2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`optional` is a newish feature of Terraform that lets us omit certain fields from node definitions. This makes node definitions much easier to read, and stops requiring us to change *all* .tfvar files each time we add another way a nodepool can be customized.
|
@consideRatio looks like the terraform autoformatter was not autoformatting tfvars files. I've fixed that now, so these should all work now I think. |
consideRatio
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optionalis a newish feature of Terraform that lets us omit certain fields from node definitions. This makes node definitions much easier to read, and stops requiring us to change all .tfvar files each time we add another way a nodepool can be customized.