Switch to jupyter/scipy-notebook as 'default'#2671
Merged
Conversation
2i2c-org#2336 lists issues with the current 'default' image, and the history of how it came to be. The primary reason for its existence was addressed in 2i2c-org#2435, so it fundamentally does not really need to exist anymore. However, there are still 4 hubs using that image, inherited from the default. This PR does the following: - Switches to jupyter/scipy-notebook as the 'default', when nothing else is specified. Note that because all our hubs have an image specified *somewhere* except for these 4 (see the spreadsheet linked to from 2i2c-org#2582), this will actually have *no effect* for existing hubs at all! Just means that *future* hubs will get this image as the default. - Explicitly sets the image for the 4 hubs still using the old 'default' image. These communities will need to be reached out to, and the image changed. After this, I believe we can archive the old 'default' image! Ref 2i2c-org#2336
consideRatio
approved these changes
Jun 19, 2023
Contributor
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5317162964 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2336 lists issues with the current 'default' image, and the history of how it came to be. The primary reason for its existence was addressed in #2435, so it fundamentally does not really need to exist anymore.
However, there are still 4 hubs using that image, inherited from the default. This PR does the following:
After this, I believe we can archive the old 'default' image!
Ref #2336 (EDIT by Erik: fixes #2336)