Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to jupyter/scipy-notebook as 'default' #2671

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

yuvipanda
Copy link
Member

@yuvipanda yuvipanda commented Jun 19, 2023

#2336 lists issues with the current 'default' image, and the history of how it came to be. The primary reason for its existence was addressed in #2435, so it fundamentally does not really need to exist anymore.

However, there are still 4 hubs using that image, inherited from the default. This PR does the following:

  • Switches to jupyter/scipy-notebook as the 'default', when nothing else is specified. Note that because all our hubs have an image specified somewhere except for these 4 (see the spreadsheet linked to from Identify where 2i2c engineers spend time on image management #2582), this will actually have no effect for existing hubs at all! Just means that future hubs will get this image as the default.
  • Explicitly sets the image for the 4 hubs still using the old 'default' image. These communities will need to be reached out to, and the image changed.

After this, I believe we can archive the old 'default' image!

Ref #2336 (EDIT by Erik: fixes #2336)

2i2c-org#2336 lists
issues with the current 'default' image, and the history of
how it came to be. The primary reason for its existence was
addressed in 2i2c-org#2435,
so it fundamentally does not really need to exist anymore.

However, there are still 4 hubs using that image, inherited
from the default. This PR does the following:

- Switches to jupyter/scipy-notebook as the 'default', when
  nothing else is specified. Note that because all our hubs
  have an image specified *somewhere* except for these 4
  (see the spreadsheet linked to from 2i2c-org#2582),
  this will actually have *no effect* for existing hubs at
  all! Just means that *future* hubs will get this image as
  the default.
- Explicitly sets the image for the 4 hubs still using the
  old 'default' image. These communities will need to be
  reached out to, and the image changed.

After this, I believe we can archive the old 'default' image!

Ref 2i2c-org#2336
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wieee looks great!!

I opened #2674 with the remaining work items you wanted to track, allowing #2336 be closed by this PR. Note that I updated the PR description with an EDIT to mark #2336 as fixed by this PR.

@yuvipanda yuvipanda merged commit b680c18 into 2i2c-org:master Jun 20, 2023
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5317162964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Intervention to have new hubs not couple to the 2i2c-hubs-image, but something more up to date
2 participants