Skip to content

Fix tflint job & linting errors in our tf code #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

yuvipanda
Copy link
Member

Without the --recursive flag, it wasn't actually checking our terraform files anymore! This PR fixes the errors reported from it.

@yuvipanda yuvipanda requested a review from a team as a code owner June 20, 2023 01:58
Without the --recursive flag, it wasn't actually checking
our terraform files anymore! This PR fixes the errors reported
from it.
@yuvipanda yuvipanda changed the title Fix tflint job Fix tflint job & linting errors in our tf code Jun 20, 2023
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I observe the removed variables as now unused

@yuvipanda yuvipanda merged commit f6c0cae into 2i2c-org:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants