Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move paleohack back to 2i2c cluster #438

Merged
merged 3 commits into from Jun 7, 2021

Conversation

yuvipanda
Copy link
Member

Fixes #409

- Moved NFS home directories - 2i2c-org#409 (comment)
- DNS needs to be switched to the new cluster
- Kept CPU & Memory limits, but dropped guarantees. Helps increase
  utilization on the cluster, since we expect the hub to be rarely
  used.

Fixes 2i2c-org#409
@yuvipanda
Copy link
Member Author

Need to move the sqlite database as well

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 🚀

I'm just wondering, do we have any documentation around moving hubs out an existing cluster?

Same for moving them back and what are the pieces that need to be permanently deleted and what needs to be kept. @yuvipanda, maybe you can give more details about this comment specifically *I move the old contents of this directory to _old - this is ok, since the users will now see the same contents.* from #409 (comment)

I guess what I'm saying is that when doing operations like moving a hub from a cluster to another, there are a few "invisible" steps from a PR's point of view, that are potentially only explained in comments (like this one) or commit messages. I would love if we get some of these steps into the docs, even if it's in the form of some generic points (I imagine there's no silver bullet that fits every scenario)

@damianavila
Copy link
Contributor

I guess what I'm saying is that when doing operations like moving a hub from a cluster to another, there are a few "invisible" steps from a PR's point of view, that are potentially only explained in comments (like this one) or commit messages. I would love if we get some of these steps into the docs, even if it's in the form of some generic points (I imagine there's no silver bullet that fits every scenario)

This is a very good point, @GeorgianaElena. If not in this PR, we should have a follow-up task to document the process.

@yuvipanda
Copy link
Member Author

@damianavila @GeorgianaElena I added docs to this PR :) LMK if that looks ok, and I'll complete the move?

@GeorgianaElena
Copy link
Member

It's perfect @yuvipanda, thank you! Adding the docs shouldn't have been a blocker for this PR though, sorry for not following up on this!

Co-authored-by: Georgiana Elena <georgiana.dolocan@gmail.com>
@yuvipanda yuvipanda merged commit 404dc0e into 2i2c-org:master Jun 7, 2021
@damianavila
Copy link
Contributor

Thanks for adding the docs @yuvipanda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move paleohack hub to pilot hubs cluster again
3 participants