Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE when removing an item #5

Open
dblock opened this issue Jul 9, 2018 · 0 comments
Open

NPE when removing an item #5

dblock opened this issue Jul 9, 2018 · 0 comments

Comments

@dblock
Copy link
Collaborator

dblock commented Jul 9, 2018

Removing an item causes the creation of a null node, whereas it should just be empty, workaround in https://github.com/33-minutes/33-minutes-app/blob/master/app/components/Meetings.js#L33.

Before removal:

Array [
5:27:13 PM:   Object {
5:27:13 PM:     "cursor": "MQ==",
5:27:13 PM:     "node": Object {
5:27:13 PM:       "__fragments": Object {
5:27:13 PM:         "Meeting_meeting": Object {},
5:27:13 PM:       },
5:27:13 PM:       "__id": "5b43d2859b0b589e40ae8a2f",
5:27:13 PM:       "__typename": "Meeting",
5:27:13 PM:     },
5:27:13 PM:   },
5:27:13 PM: ]

After:

5:27:15 PM: Array [
5:27:15 PM:   Object {
5:27:15 PM:     "cursor": "MQ==",
5:27:15 PM:     "node": null,
5:27:15 PM:   },
5:27:15 PM: ]

Possibly related to facebook/relay#2155?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant