Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix feature matching #63

Merged
merged 5 commits into from
Jun 19, 2024
Merged

fix: fix feature matching #63

merged 5 commits into from
Jun 19, 2024

Conversation

34j
Copy link
Owner

@34j 34j commented Jun 19, 2024

Description of change

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request follows Contributing.md
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec, such as "fix(api): prevent racing of requests".
  • If pre-commit.ci is failing, try pre-commit run -a for further information.
  • If CI / test is failing, try poetry run pytest for further information.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 18.42105% with 31 lines in your changes missing coverage. Please review.

Project coverage is 51.30%. Comparing base (1177d95) to head (28f31ba).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/vr180_convert/cli.py 16.00% 20 Missing and 1 partial ⚠️
src/vr180_convert/remapper.py 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   52.53%   51.30%   -1.23%     
==========================================
  Files           6        6              
  Lines         592      612      +20     
  Branches      108      111       +3     
==========================================
+ Hits          311      314       +3     
- Misses        257      273      +16     
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@34j 34j merged commit 18cd8aa into main Jun 19, 2024
18 of 20 checks passed
@34j 34j deleted the feat/akaze branch June 19, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant