Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starter ESLint config #10

Merged
merged 1 commit into from Sep 12, 2019
Merged

Add starter ESLint config #10

merged 1 commit into from Sep 12, 2019

Conversation

@EvanHahn
Copy link
Collaborator

EvanHahn commented Sep 11, 2019

This adds a basic ESLint configuration. All of the recommended rules are present here, though some of them have been turned from errors to warnings because the source code has some mistakes.

In subsequent changes, we should turn these warnings into errors and fix the source code. We should also consider using ESLint to enforce code style (like indentation) and other things.

This adds a basic ESLint configuration. All of the [recommended
rules][1] are present here, though some of them have been turned from
errors to warnings because the source code has some mistakes.

In subsequent changes, we should turn these warnings into errors and fix
the source code. We should also consider using ESLint to enforce code
style (like indentation) and other things.

[1]: https://eslint.org/docs/rules/
Copy link
Collaborator

dtoakley left a comment

Looks good. LMTD

@dtoakley dtoakley merged commit 6fa9434 into master Sep 12, 2019
5 checks passed
5 checks passed
Header rules - 350poster No header rules processed
Details
Pages changed - 350poster All files already uploaded
Details
Redirect rules - 350poster No redirect rules processed
Details
Mixed content - 350poster No mixed content detected
Details
netlify/350poster/deploy-preview Deploy preview ready!
Details
@dtoakley dtoakley deleted the add_starter_eslint_config branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.