Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wdm gem from version 0.1.0 to 0.1.1 #7

Merged
merged 1 commit into from Sep 11, 2019
Merged

Conversation

@EvanHahn
Copy link
Collaborator

EvanHahn commented Sep 10, 2019

This upgrades the wdm gem to the latest version, 0.1.1. The best way to see what changed is by looking at the diff between the two versions—unfortunately, the changelog was removed in this version, so it's a little harder to see what this means in English.

I didn't test this because I'm not on Windows, but I feel comfortable upgrading the gem given that it's a patch version. I can spin up a Windows VM and test this out, if helpful.

This partially addresses #2.

This upgrades the `wdm` gem to the latest version, `0.1.1`. The best way
to see what changed is by looking at [the diff between the two
versions][1]—unfortunately, the changelog was removed in this version,
so it's a little harder to see what this means in English.

I didn't test this because I'm not on Windows, but I feel comfortable
upgrading the gem given that it's a patch version. I can spin up a
Windows VM and test this out, if helpful.

This partially addresses [issue #2][2].

[1]: https://github.com/Maher4Ever/wdm/compare/v0.1.0..v0.1.1
[2]: #2
@dtoakley

This comment has been minimized.

Copy link
Collaborator

dtoakley commented Sep 11, 2019

I think we'll want to do a quick test with a Windows VM before promoting the app live, so I think doing it now before we merge makes more sense as we might forget later. If you can do that @EvanHahn that would be great.

@EvanHahn

This comment has been minimized.

Copy link
Collaborator Author

EvanHahn commented Sep 11, 2019

I'm happy to do that, but probably won't be able to get to it for a few days. Does it change your mind knowing that this is a development-only dependency?

@dtoakley

This comment has been minimized.

Copy link
Collaborator

dtoakley commented Sep 11, 2019

Approved!

@EvanHahn EvanHahn merged commit 7d7dbe0 into master Sep 11, 2019
5 checks passed
5 checks passed
Header rules - 350poster No header rules processed
Details
Pages changed - 350poster All files already uploaded
Details
Redirect rules - 350poster No redirect rules processed
Details
Mixed content - 350poster No mixed content detected
Details
netlify/350poster/deploy-preview Deploy preview ready!
Details
@EvanHahn EvanHahn deleted the upgrade_wdm_gem_to_0.1.1 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.