Upgrade to Middleman 4 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades from Middleman 3.3.3 to 4.3.5. That entailed: 1. Upgrading the `middleman` and `middleman-livereload` gems. 2. In the config, converting `set` calls to updates to the `config` hash. This wasn't strictly necessary, but [Middleman's docs claim that it's a "somewhat newer syntax"][1], so I thought I'd future-proof while I was there. 3. Removed Compass. While the ["Upgrading to v4" doc][2] claims that Compass was "still bundled by default", I was never able to reproduce this. A `git grep -i compass` in the Middleman source gave nothing helpful (four comments and one log message; no installed `compass` gem or similar). Luckily, we were only using Compass in three places—one that was completely unused (`user-select`), one that was easy to replicate (the `appearance` mixin), and one that I felt safe to replace with the version built into browsers (`transition`). 4. Replaced Sprockets directives with a bunch of included JavaScript files. Sprockets seems to have been removed from Middleman v4 and relegated to the [`middleman-sprockets` extension][3], but that immediately crashed with Sass-related errors (seemingly because it was unable to require the [deprecated-since-March `sass` gem][4]). I replaced this with a bunch of `<script>` tags. While I'd prefer to concatenate these files, that would require setting up some additional infrastructure which I felt was out of scope for this commit. Closes [issue #2][5]. [1]: https://middlemanapp.com/advanced/configuration/#changing-settings [2]: https://middlemanapp.com/basics/upgrade-v4/ [3]: https://github.com/middleman/middleman-sprockets [4]: https://sass-lang.com/ruby-sass [5]: #2
EvanHahn
force-pushed
the
upgrade_to_middleman_4
branch
from
7e9b813
to
67cf6e1
Compare
dtoakley
approved these changes
Sep 12, 2019
Looks good and my locally testing worked well! LMTD (let's merge this down)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit upgrades from Middleman 3.3.3 to 4.3.5. That entailed:
middlemanandmiddleman-livereloadgems.setcalls to updates to theconfighash. This wasn't strictly necessary, but Middleman's docs claim that it's a "somewhat newer syntax", so I thought I'd future-proof while I was there.git grep -i compassin the Middleman source gave nothing helpful (four comments and one log message; no installedcompassgem or similar). Luckily, we were only using Compass in three places—one that was completely unused (user-select), one that was easy to replicate (theappearancemixin), and one that I felt safe to replace with the version built into browsers (transition).middleman-sprocketsextension, but that immediately crashed with Sass-related errors (seemingly because it was unable to require the deprecated-since-Marchsassgem). I replaced this with a bunch of<script>tags. While I'd prefer to concatenate these files, that would require setting up some additional infrastructure which I felt was out of scope for this commit.Closes #2.