In some conditions, nunc-stans would report a timeout incorrectly

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49171

• Created at 2017-03-15 01:45:03 by firstyear (@Firstyear)
• Closed at 2017-03-15 05:21:09 as fixed
• Assigned to nobody
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1404409

---

Issue Description

In some conditions we were not handling timeouts correctly: Especially infinite timeouts.

We should improve our check in daemon.c to check for the idletimeout and warn us if this is occuring. We alter the event output function to give us TIMEOUT | (READ, SIGNAL, WRITE), so that we have a clear barrier between the two.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-03-15 01:48:38

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-03-15 01:48:48

Metadata Update from @Firstyear:

• Custom field reviewstatus adjusted to new
• Custom field type adjusted to defect

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-03-15 01:49:10

Metadata Update from @Firstyear:

• Custom field reviewstatus adjusted to review (was: new)

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-15 02:20:04

48 + slapi_log_err(SLAPI_LOG_ERR, "ns_handle_pr_read_ready", "Recieved idletime out with c->c_idletimeout as 0. Ignoring.\n");

"received" is spelled wrong, and the indentation in daemon.c is off as well.

I'll assume you'll fix these two minor issues, ack.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-15 02:20:14

Metadata Update from @mreynolds389:

• Custom field reviewstatus adjusted to ack (was: review)

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-15 02:21:33

And that logging line, should we log a warning instead of an error? SLAPI_LOG_WARN?

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-03-15 02:49:02

commit c8ce1b3
To ssh://git@pagure.io/389-ds-base.git
c75126b..c8ce1b3 master -> master

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-03-15 03:03:29

commit 1d0ff1d
To ssh://git@pagure.io/389-ds-base.git
c8ce1b3..1d0ff1d master -> master

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-03-15 05:20:51

Metadata Update from @Firstyear:

• Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1404409

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-03-15 05:21:15

Metadata Update from @Firstyear:

• Issue close_status updated to: fixed
• Issue status updated to: Closed (was: Open)