Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - add console logging function #3037

Closed
389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Closed

UI - add console logging function #3037

389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Labels
closed: fixed Migration flag - Issue
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49978


Issue Description

We are logging, console.log(), all the CLI commands in the UI. To make sure the formatting is consistent we should create a simple logging function:

log_cmd(js_function_name, cmd_description_text, cmd_array);

log_cmd("load_repl_config", "Load all the replication data into the UI forms", cmd);

Console output:

CMD: load_repl_config - Load all the replication data into the UI forms: dsconf -j ldapi://%2fvar%2frun%2fslapd-localhost.socket replication get --suffix=dc=example,dc=com
@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 13, 2020
@389-ds-bot 389-ds-bot added this to the 1.4.0 milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2018-10-16 10:54:37

Good idea. Additionally, however, I believe the logging itself should be turned off by default in production, and only turned on when the user explicitly asks for it, maybe some hidden checkbox. And, the call itself should be guarded for existence as the console.log() may not be present in some browsers, hence it has potential to generate a lot of errors in the console itself.

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2018-10-16 10:54:38

Metadata Update from @kenoh:

  • Custom field component adjusted to None
  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None
  • Custom field type adjusted to None
  • Custom field version adjusted to None

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2018-10-17 01:01:42

@kenoh Flip side is that console logging is cheap on the client, and will make error report submissions simpler. I think logging by default is fine for this application,

However, console.log not being universal ... is that true? I would hope we could find a way to standardise or detect what logging we need inside the log_cmd.

@389-ds-bot
Copy link
Author

389-ds-bot commented Sep 13, 2020

Comment from mreynolds (@mreynolds389) at 2018-10-18 00:02:25

#3041

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-10-18 00:02:27

Metadata Update from @mreynolds389:

  • Custom field reviewstatus adjusted to review (was: None)

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-10-23 16:29:05

Metadata Update from @mreynolds389:

  • Issue close_status updated to: fixed
  • Issue status updated to: Closed (was: Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant