Skip to content

Add a check for tagged commits #6047

Closed
@vashirov

Description

@vashirov

Issue Description
Release on GitHub can be created from a tag that points to a branch-less commit.
For example, releases starting from 2.4.1 are affected by this:

$ for i in $(seq 0 5); do git checkout 389-ds-base-2.4.$i; git branch -a --contains $(git rev-parse HEAD); done
Previous HEAD position was 3db81913e Bump version to 2.3.0
HEAD is now at 87efeb29a Bump version to 2.4.0
* (HEAD detached at 389-ds-base-2.4.0)
  main
  remotes/origin/389-ds-base-2.4
  remotes/origin/389-ds-base-2.5
  remotes/origin/HEAD -> origin/main
  remotes/origin/main
Previous HEAD position was 87efeb29a Bump version to 2.4.0
HEAD is now at 0906b610f Bump version to 2.4.1
* (HEAD detached at 389-ds-base-2.4.1)
Previous HEAD position was 0906b610f Bump version to 2.4.1
HEAD is now at 0dbf7d2ac Bump version to 2.4.2
* (HEAD detached at 389-ds-base-2.4.2)
Previous HEAD position was 0dbf7d2ac Bump version to 2.4.2
HEAD is now at e2581ae17 Bump version to 2.4.3
* (HEAD detached at 389-ds-base-2.4.3)
Previous HEAD position was e2581ae17 Bump version to 2.4.3
HEAD is now at 2cb07156d Bump version to 2.4.4
* (HEAD detached at 389-ds-base-2.4.4)
Previous HEAD position was 2cb07156d Bump version to 2.4.4
HEAD is now at 33c0e0115 Bump version to 2.4.5
* (HEAD detached at 389-ds-base-2.4.5)

I'm not sure how we end up with 2 "Bump version" commits where one is tagged, and another one is in the branch but not tagged. At least we should ensure that our releases point to the right commit in the branch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs triageThe issue will be triaged during scrum

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions