logconv.py: python3-magic conflicts with python3-file-magic

[vashirov]

Issue Description
From:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d546c237ea#comment-3931147

So this is failing tests because 389-ds-base added a dependency on "python-magic", and that seems to cause a conflict:

2025-01-24T20:16:39+0000 [3587] ERROR Problem 1: package 389-ds-base-3.1.2-1.fc42.x86_64 from advisory requires python-magic, but none of the providers can be installed
  - installed package python3-file-magic-5.45-9.fc42.noarch conflicts with python3-magic provided by python3-magic-0.4.27-10.fc42.noarch from koji-rawhide
  - installed package python3-file-magic-5.45-9.fc42.noarch conflicts with python3-magic provided by python3-magic-0.4.27-10.fc42.noarch from rawhide
  - cannot install the best update candidate for package python3-file-magic-5.45-9.fc42.noarch
  - cannot install the best update candidate for package 389-ds-base-3.1.1-6.fc42.x86_64
 Problem 2: problem with installed package
  - installed package python3-file-magic-5.45-9.fc42.noarch conflicts with python3-magic provided by python3-magic-0.4.27-10.fc42.noarch from koji-rawhide
  - package python3-file-magic-5.45-9.fc42.noarch from koji-rawhide conflicts with python3-magic provided by python3-magic-0.4.27-10.fc42.noarch from koji-rawhide
  - package python3-file-magic-5.45-9.fc42.noarch from rawhide conflicts with python3-magic provided by python3-magic-0.4.27-10.fc42.noarch from koji-rawhide
  - package 389-ds-base-3.1.2-1.fc42.x86_64 from advisory requires python-magic, but none of the providers can be installed
  - installed package python3-file-magic-5.45-9.fc42.noarch conflicts with python3-magic provided by python3-magic-0.4.27-10.fc42.noarch from rawhide
  - package python3-file-magic-5.45-9.fc42.noarch from koji-rawhide conflicts with python3-magic provided by python3-magic-0.4.27-10.fc42.noarch from rawhide
  - package python3-file-magic-5.45-9.fc42.noarch from rawhide conflicts with python3-magic provided by python3-magic-0.4.27-10.fc42.noarch from rawhide
  - package python3-lib389-3.1.2-1.fc42.noarch from advisory requires 389-ds-base = 3.1.2-1.fc42, but none of the providers can be installed
  - cannot install the best update candidate for package python3-lib389-3.1.1-6.fc42.noarch

Basically we already have python3-file-magic installed, and it conflicts with python3-magic, so the newer 389-ds-base cannot be installed. I think we have python3-file-magic installed in the test environment because sos depends on it, and sos is in the 'standard' comps group, and server-product-environment includes 'standard', so it's in a default Server package set. It's also in any other package set that includes 'standard', and it's also in Workstation because it's in the 'workstation-product' group directly. So, this 389-ds-base won't be installable in a lot of configs (pretty much only minimal installs will be OK).

CC: @jchapma

[AdamWill]

Just for clarity on what these are: the Fedora python3-file-magic package is built out of the file source package, which is https://astron.com/pub/file/ . It exists on pypi as file-magic - https://pypi.org/project/file-magic/ .

The Fedora python3-magic package is built out of the python-magic source package, which is https://github.com/ahupp/python-magic . It exists on pypi as python-magic - https://pypi.org/project/python-magic/ .

They both provide a Python library called magic, which is why they conflict. They both, AFAICS, do the same thing, and ultimately are just wrappers around libmagic. I don't know why both need to exist, or be in Fedora. We seem to have an even split between things requiring python3-file-magic:

autokey-common-0:0.96.0-10.fc42.noarch
cobbler-0:3.3.7-3.fc42.noarch
diffoscope-0:285-1.fc42.x86_64
python3-ginga+recommended-0:5.1.0-3.fc42.noarch
python3-pass-import+decrypt-0:3.5-2.fc42.noarch
rpmlint-0:2.6.1-2.fc42.noarch

and things requiring python3-magic:

alot-0:0.11-2.fc42.noarch
gnome-feeds-0:2.2.0-2.fc42.noarch
python3-Mastodon-0:1.8.1-8.fc42.noarch
retrace-server-0:1.24.2-9.fc42.noarch
s3cmd-0:2.4.0-5.fc42.noarch

...which is a bit unfortunate. It means you can't install any of those things together.

diffoscope gets a gold star for requiring python3-file-magic and recommending python3-magic, which is, er, impossible to respect. Ah, well.

We might need to address this at a bit of a wider level long-term, but short-term, I think it'd make sense to use python3-file-magic instead of python3-magic for 389-ds-base. The patch would be something like this:

diff --git a/ldap/admin/src/logconv.py b/ldap/admin/src/logconv.py
index 566f9af38..2fb5bb8c1 100755
--- a/ldap/admin/src/logconv.py
+++ b/ldap/admin/src/logconv.py
@@ -1798,8 +1798,7 @@ class logAnalyser:
             return None
 
         try:
-            mime = magic.Magic(mime=True)
-            filetype = mime.from_file(filepath)
+            filetype = magic.detect_from_filename(filepath).mime_type
 
             # List of supported compression types
             compressed_mime_types = [
diff --git a/rpm/389-ds-base.spec.in b/rpm/389-ds-base.spec.in
index 1b408be0f..74bcb4576 100644
--- a/rpm/389-ds-base.spec.in
+++ b/rpm/389-ds-base.spec.in
@@ -200,7 +200,7 @@ Requires:         json-c
 # Log compression
 Requires:         zlib-devel
 # logconv.py, MIME type
-Requires:         python-magic
+Requires:         python3-file-magic
 # Picks up our systemd deps.
 %{?systemd_requires}
 

completely untested, so not sending as a PR...

[AdamWill]

Found an existing forum post about this mess: https://discussion.fedoraproject.org/t/is-it-possible-to-unravel-the-python-magic-packaging-clusterfsck/136792/4

[vashirov]

I think it'd make sense to use python3-file-magic instead of python3-magic for 389-ds-base.

I agree. On CentOS Stream 10 there is only python3-file-magic:

# repoquery --whatprovides python3-magic
...
python3-file-magic-0:5.45-7.el10.noarch

While on Fedora 41:

# repoquery --whatprovides python3-magic
...
python3-file-magic-0:5.45-7.fc41.noarch
python3-magic-0:0.4.27-9.fc41.noarch

Your suggested fix works, at least I'm able to feed access.gz to logconv.py on a system with python3-file-magic installed.
I'll submit a PR on your behalf if you don't mind.

[vashirov]

92fc2f3..82fe212 389-ds-base-3.0 -> 389-ds-base-3.0