Multiple issues around error log messages

[progier389]

Issue Description
Because of https://issues.redhat.com/browse/RHEL-61327 report,
I wrote a tool to check that slapi_log_err calls have proper functionm name and final \n in the message.
The tool reported 48 missinmg newline and 3 missing function name:

/home/progier/sb/389/389-ds-base/ldap/servers/plugins/replication/repl5_inc_protocol.c[1731]: missing function name when calling slapi_log_err (args="send_updates - %s: Failed to send update operation to receiver (uniqueid %s, CSN %s): %s. %s.\n")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/daemon.c[585]: missing final newline when calling slapi_log_err (args="Too many backends match search request - cannot proceed")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/passwd_extop.c[476]: missing final newline when calling slapi_log_err (args="%s")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/passwd_extop.c[506]: missing final newline when calling slapi_log_err (args="%s")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/passwd_extop.c[514]: missing final newline when calling slapi_log_err (args="%s")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/passwd_extop.c[841]: missing final newline when calling slapi_log_err (args="%s")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/util.c[980]: missing final newline when calling slapi_log_err (args="Pathname \"%s")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/util.c[1547]: missing final newline when calling slapi_log_err (args="Invalid adjusted cachesize is greater than request %"PRIu64)
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/sasl_io.c[378]: missing final newline when calling slapi_log_err (args="read sasl packet length %")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/sasl_io.c[411]: missing final newline when calling slapi_log_err (args="Reading %")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/sasl_io.c[442]: missing final newline when calling slapi_log_err (args="Connection %"PRIu64" len %d bytes_in_buffer %")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/sasl_io.c[445]: missing final newline when calling slapi_log_err (args="Connection %"PRIu64" len %d encrypted buffer count %")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/sasl_io.c[534]: missing final newline when calling slapi_log_err (args="Returning %")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/ldbm_add.c[639]: missing final newline when calling slapi_log_err (args="Maximum ID reached, cannot add entry to ""backend '%s'")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/vlv.c[1673]: missing final newline when calling slapi_log_err (args="Attempt to compare an unordered attribute")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/ldbm_usn.c[126]: missing final newline when calling slapi_log_err (args="Failed to create a cursor: %d")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/idl.c[1374]: missing function name when calling slapi_log_err (args="idl_old_delete_key - (%s) 0 BAD %d %s\n")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-mdb/mdb_ldif2db.c[1393]: missing final newline when calling slapi_log_err (args="Failed to position cursor at ID ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-mdb/mdb_ldif2db.c[1400]: missing final newline when calling slapi_log_err (args="Failed to get rdn of entry ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-mdb/mdb_ldif2db.c[1407]: missing final newline when calling slapi_log_err (args="Failed to add rdn %s of entry ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/filterindex.c[1147]: missing final newline when calling slapi_log_err (args="   ival[%")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/ldbm_delete.c[969]: missing final newline when calling slapi_log_err (args="delete (updating ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_config.c[288]: missing final newline when calling slapi_log_err (args="%s was set to '0'. The default value will be used (%s)")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_config.c[319]: missing final newline when calling slapi_log_err (args="%s: \"%d\" is invalid, threshold is indicated as a percentage and it must lie in range of 70 and 95")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_import_threads.c[1756]: missing final newline when calling slapi_log_err (args="%s: Error: failed to write a line \"%s\"")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_import_threads.c[3557]: missing final newline when calling slapi_log_err (args="Skipping bad LDIF entry ending line %d of file \"%s\"")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_import_threads.c[3708]: missing final newline when calling slapi_log_err (args="Failed to position at ID ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_import_threads.c[3715]: missing final newline when calling slapi_log_err (args="Failed to get rdn of entry ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_import_threads.c[3722]: missing final newline when calling slapi_log_err (args="Failed to add rdn %s of entry ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_ldif2db.c[2763]: missing final newline when calling slapi_log_err (args="Failed to position cursor at ID ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_ldif2db.c[2770]: missing final newline when calling slapi_log_err (args="Failed to get rdn of entry ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_ldif2db.c[2777]: missing final newline when calling slapi_log_err (args="Failed to add rdn %s of entry ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_misc.c[243]: missing final newline when calling slapi_log_err (args="%s")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_misc.c[385]: missing final newline when calling slapi_log_err (args="%s")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_import.c[322]: missing final newline when calling slapi_log_err (args="Unable to find entry id [")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_import.c[926]: missing final newline when calling slapi_log_err (args="Failure: bdb_parentid on node index [")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.c[592]: missing final newline when calling slapi_log_err (args="page_size=%")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.c[593]: missing final newline when calling slapi_log_err (args="index_page_size=%")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/log.c[1215]: missing final newline when calling slapi_log_err (args="Invalid log type %d")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/log.c[4502]: missing final newline when calling slapi_log_err (args="LOGINFO:End of Log because size exceeded(Max:%")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/schema.c[6566]: missing final newline when calling slapi_log_err (args="Not able to build an attributes list from the consumer schema")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/modrdn.c[573]: missing final newline when calling slapi_log_err (args="conn=%"PRIu64" op=%d MODRDN invalid new superior (\"%s\")")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/modrdn.c[579]: missing final newline when calling slapi_log_err (args="conn=%s op=%d MODRDN invalid new superior (\"%s\")")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/libglobs.c[1769]: missing final newline when calling slapi_log_err (args="Failed to initialize cfg_rwlock. Exiting now.")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/libglobs.c[1775]: missing final newline when calling slapi_log_err (args="Failed to initialize cfg_lock. Exiting now.")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/main.c[916]: missing final newline when calling slapi_log_err (args="Unable to access ")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/filterentry.c[831]: missing final newline when calling slapi_log_err (args="⚠️  DANGER ⚠️  - only_check_access mode is BROKEN!!! YOU MUST CHECK ACCESS WITH FILTER MATCHING")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/bind.c[150]: missing final newline when calling slapi_log_err (args="BIND dn=\"%s\" method=%")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/pw.c[248]: missing final newline when calling slapi_log_err (args="Invalid scheme - %s\n""no pwdstorage scheme plugin loaded")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/entry.c[893]: missing function name when calling slapi_log_err (args="str2entry_dupcheck""Entry has multiple dns \"%s\" and \"%s\" (second ignored)\n")
/home/progier/sb/389/389-ds-base/ldap/servers/slapd/ldaputil.c[1308]: missing final newline when calling slapi_log_err (args="Unable to add authentication response control")

Package Version and Platform:

• Platform: Fedora
• Package and version: main branch

[progier389]

Triaged: https://issues.redhat.com/browse/IDMDS-4852

[vashirov]

@progier389 could you please backport it down to 2.4?

[progier389]

7fbd452..b550579 main -> main
0cee387..f16e187 389-ds-base-3.0 -> 389-ds-base-3.0
ed0b749..feb341c 389-ds-base-2.6 -> 389-ds-base-2.6
c87f50e..387436b 389-ds-base-2.5 -> 389-ds-base-2.5
c9f11b0..f7e937c 389-ds-base-2.4 -> 389-ds-base-2.4