Issue 6049 - lmdb - changelog is wrongly recreated by reindex task #6050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbordaz
reviewed
Jan 25, 2024
| @@ -736,7 +736,11 @@ dbmdb_import_all_done(ImportJob *job, int ret) | |||
| ldbm_set_last_usn(inst->inst_be); | |||
|
|
|||
| /* bring backend online again */ | |||
| slapi_mtn_be_enable(inst->inst_be); | |||
| if (job->flags & FLAG_REINDEXING) { | |||
There was a problem hiding this comment.
Looking at bdb_import_all_done we have similar lines (enable backend even in case of reindex). Should it be also fixed in bdb_import_all_done ?
There was a problem hiding this comment.
No: Unlike in lmdb, bdb_import_all_done is not called after bdb_db2index (And that is why there is no problem with bdb)
That is due to a difference in the way xxx_db2index are coded:
- bdb: The function is quite large (864 lines) because it prepares the reindex - performs the reindex - sets back backend in non_busy mode. BTW that is why bdb reindex is slower than import
- mdb: The function is simpler (85 lines) because it simply prepare the reindex then reuse the import framework pipeline (in lmdb, the reindex processing is quite similar to the import except than data are read from entryid instead of ldif)
| @@ -736,7 +736,11 @@ dbmdb_import_all_done(ImportJob *job, int ret) | |||
| ldbm_set_last_usn(inst->inst_be); | |||
|
|
|||
| /* bring backend online again */ | |||
| slapi_mtn_be_enable(inst->inst_be); | |||
| if (job->flags & FLAG_REINDEXING) { | |||
| instance_set_not_busy(inst); | |||
There was a problem hiding this comment.
Fix looks good. A bit painful to retrieve where it was set, I found bdb_db2index and dbmdb_db2index. Do you mind to put a comment from where the BUSY flag was set.
There was a problem hiding this comment.
Ok, I will add a comment
tbordaz
approved these changes
Jan 25, 2024
progier389
added a commit
that referenced
this pull request
May 30, 2024
…6050) * Issue 6049 - using lmdb the changelog is wrongly recreated by reindex task dbmdb_import_all_done called at the end of import, bulk import and reindex is reenabling the backend which trigger the replication plugin to check if data were not reloaded, but in the reindex case, the backend was not disabled (so the db ruv is not up to date) and changelog is then discarded . The solution is to set back the backend in not busy mode when doing a reindex. Issue: #6049 Reviewed by: @tbordaz (Thanks!) (cherry picked from commit d7e255a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbmdb_import_all_done called at the end of import, bulk import and reindex is reenabling the backend
which trigger the replication plugin to check if data were not reloaded, but in the reindex case, the backend was not disabled (so the db ruv is not up to date) and changelog is then discarded .
The solution is to set back the backend in not busy mode when doing a reindex.
Issue: #6049
Reviewed by: @tbordaz (Thanks!)