Skip to content

Issue 3555 - Remove audit-ci from dependencies #6056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

droideck
Copy link
Member

Description: We use npx for audit-ci runs. Hence we don't need the package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: ?

Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: 389ds#3555

Reviewed by: ?
Copy link
Member

@vashirov vashirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a system where audit-ci was not previously installed, make -f rpms stops with

npx audit-ci
Need to install the following packages:
audit-ci@6.6.1
Ok to proceed? (y)

We should update Makefile.am and rpm.mk to use npx --yes audit-ci instead.

@droideck droideck requested a review from vashirov January 29, 2024 16:48
@droideck droideck merged commit 539bb0f into 389ds:main Jan 29, 2024
droideck added a commit that referenced this pull request Jan 29, 2024
Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: @vashirov (Thanks!)
droideck added a commit that referenced this pull request Jan 29, 2024
Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: @vashirov (Thanks!)
droideck added a commit that referenced this pull request Jan 29, 2024
Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: @vashirov (Thanks!)
droideck added a commit that referenced this pull request Jan 29, 2024
Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: @vashirov (Thanks!)
droideck added a commit that referenced this pull request Jan 29, 2024
Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: @vashirov (Thanks!)
droideck added a commit that referenced this pull request Jan 29, 2024
Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: @vashirov (Thanks!)
droideck added a commit that referenced this pull request Jan 29, 2024
Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: @vashirov (Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants