Issue 3555 - Remove audit-ci from dependencies#6056
Merged
Conversation
Description: We use npx for audit-ci runs. Hence we don't need the package installed at all. Remove audit-ci from package.json and a new generate package-lock.json. Related: 389ds#3555 Reviewed by: ?
vashirov
requested changes
Jan 29, 2024
vashirov
left a comment
vashirov
left a comment
Member
There was a problem hiding this comment.
On a system where audit-ci was not previously installed, make -f rpms stops with
npx audit-ci
Need to install the following packages:
audit-ci@6.6.1
Ok to proceed? (y)
We should update Makefile.am and rpm.mk to use npx --yes audit-ci instead.
vashirov
approved these changes
Jan 29, 2024
droideck
added a commit
that referenced
this pull request
Jan 29, 2024
droideck
added a commit
that referenced
this pull request
Jan 29, 2024
droideck
added a commit
that referenced
this pull request
Jan 29, 2024
droideck
added a commit
that referenced
this pull request
Jan 29, 2024
droideck
added a commit
that referenced
this pull request
Jan 29, 2024
droideck
added a commit
that referenced
this pull request
Jan 29, 2024
droideck
added a commit
that referenced
this pull request
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: We use npx for audit-ci runs. Hence we don't need the package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.
Related: #3555
Reviewed by: ?