Issue 6067 - Improve dsidm CLI No Such Entry handling

[droideck]

Add additional error processing to dsidm CLI tool for when basedn or OU subentries are absent.

Related: #6067

Reviewed by: ?

[vashirov]

It's still a bit awkward that it allows to enter some details only to fail later:

dsidm localhost -b dc=example,dc=com service create
Enter value for cn : test
Enter value for description : test
Error: The base DN "ou=Services,dc=example,dc=com" does not exist

But the new error message is an improvement :)
LGTM

[droideck]

It's still a bit awkward that it allows to enter some details only to fail later:

dsidm localhost -b dc=example,dc=com service create
Enter value for cn : test
Enter value for description : test
Error: The base DN "ou=Services,dc=example,dc=com" does not exist

But the new error message is an improvement :) LGTM

Okay, it was actually another typo in the same code area (services instead of service).
Now it should correctly display Error: The DN "ou=Services,dc=example,dc=com" does not exist. It is required for "service" subcommand. Please create it first. error.

[Firstyear]

Sorry to re-open this one, but shouldn't

389-ds-base/src/lib389/lib389/cli_idm/__init__.py

Line 55 in 8366819

def _get_basedn_arg(inst, args, log, msg=None):

be reading the basedn from dsrc as well? Else you always need it with -b.

[progier389]

Hi @Firstyear .
IMHO, it would change the current behavior:
If I understood rightly in current code the base dn is interactively asked if -b option is missing (like for other dsidm mandatory options).
So if we use a default value from dsrc there will be no way to interactively ask for values
unless we choose to drastically change the interface (for example by adding an interactive mode option)
I have no strong feeling about that (on the plus side: it would make dsidm more like the other dsxxx commands,
but on the minus side it will change the interface and may disrupt some customer scripts/habits.)
In any case, if we want to pursue this idea, I think it is unrelated to the original issue and deserves its own ticket.
What do you think ?

[Firstyear]

But if the default value is set, it's assumed the admin wants to use that unless they override it with -b?

We had a customer report this as a regression in behaviour, which is why I bring it up :)

edit: https://bugzilla.suse.com/show_bug.cgi?id=1231462

[droideck]

But if the default value is set, it's assumed the admin wants to use that unless they override it with -b?

We had a customer report this as a regression in behaviour, which is why I bring it up :)

edit: https://bugzilla.suse.com/show_bug.cgi?id=1231462

I agree. I think it should be [check if -b provided] -> if not -> [check if basedn is in .dsrc] -> if not -> [ask interactively].
I'll prepare PR, it's an easy fix.