Issue 6080 - ns-slapd crash in referint_get_config #6081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progier389
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Sorry, but the fix looks wrong:
[1] Not sure you really want to lose the pending changes at shutdown
[2] It does not ensure that the thread is really stopped when destroying the config.
IMHO After resetting the keeprunning flag in referint_postop_close once the keeprunning_mutex is released you have to wait for the thread completion before going on with the clean up
|
Thanks for the review. You are correct the first patch was wrong. I changed the mechanism to sync plugin stop fct with the batch thread. |
progier389
approved these changes
Mar 15, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: 389ds#6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
tbordaz
added a commit
that referenced
this pull request
Mar 18, 2024
Bug description: Referential integrity plugin spawn a thread to run integrity check/update in a deferred way. It uses a log file to pipe changes to check. The name of the file, stored in the config, is read periodically. At shutdown, referint plugin close callback notifies the thread to stop and free the config. The problem is that the thread may check the config while it was notify to stop. Fix description: synchronize the plugin close function (referint_postop_close) and the batch thread (referint_thread_func). When the batch thread starts it set 'batch_thread_running' and reset it when it stops. The plugin close function notifes the batch thread to stop (via keeprunning==0) and then wait 'batch_thread_running' is reset relates: #6080 Reviewed by: Pierre Rogier (thanks !)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
Referential integrity plugin spawn a thread to run
integrity check/update in a deferred way. It uses a log
file to pipe changes to check. The name of the file,
stored in the config, is read periodically.
At shutdown, referint plugin close callback notifies
the thread to stop and free the config.
The problem is that the thread may check the config
while it was notify to stop.
Fix description:
Check the notification (keeprunning) before reading
the config
relates: #6080
Reviewed by: