Issue 5487 - Fix various isses with logconv.pl #6085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug description: Logconv.pl CSV file contains mismatched header and data columns Fix description: Add notesF to support invalid filters Relates: 389ds#5487 Reviewed by:
progier389
reviewed
Feb 8, 2024
| $stats->{'etime'}), | ||
| "\n" ); | ||
| } else { | ||
| $stats->{'fh'}->print( | ||
| "Time,time_t,Results,Search,Add,Mod,Modrdn,Moddn,Compare,Delete,Abandon,". | ||
| "Connections,SSL Conns,Bind,Anon Bind,Unbind,Unindexed search,Unindexed component,ElapsedTime\n" | ||
| "Connections,SSL Conns,Bind,Anon Bind,Unbind,Unindexed search,Unindexed component,Invalid filter,ElapsedTime\n" |
There was a problem hiding this comment.
I do not think that "Invalid" is the right term .I would rather say "Inefficient"
There was a problem hiding this comment.
This term is documented:
https://www.port389.org/docs/389ds/design/filter-syntax-verification.html
So I'd rather stick with it.
vashirov
approved these changes
Feb 13, 2024
jchapma
added a commit
that referenced
this pull request
Feb 14, 2024
Bug description: Logconv.pl CSV file contains mismatched header and data columns Fix description: Add notesF to support invalid filters Relates: #5487 Reviewed by: @progier389, @vashirov (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 14, 2024
Bug description: Logconv.pl CSV file contains mismatched header and data columns Fix description: Add notesF to support invalid filters Relates: #5487 Reviewed by: @progier389, @vashirov (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 14, 2024
Bug description: Logconv.pl CSV file contains mismatched header and data columns Fix description: Add notesF to support invalid filters Relates: #5487 Reviewed by: @progier389, @vashirov (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 14, 2024
Bug description: Logconv.pl CSV file contains mismatched header and data columns Fix description: Add notesF to support invalid filters Relates: #5487 Reviewed by: @progier389, @vashirov (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 14, 2024
Bug description: Logconv.pl CSV file contains mismatched header and data columns Fix description: Add notesF to support invalid filters Relates: #5487 Reviewed by: @progier389, @vashirov (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 14, 2024
Bug description: Logconv.pl CSV file contains mismatched header and data columns Fix description: Add notesF to support invalid filters Relates: #5487 Reviewed by: @progier389, @vashirov (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 14, 2024
Bug description: Logconv.pl CSV file contains mismatched header and data columns Fix description: Add notesF to support invalid filters Relates: #5487 Reviewed by: @progier389, @vashirov (Thank you)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description: Logconv.pl CSV file contains mismatched header and data columns
Fix description: Add notesF to support invalid filters
Relates: #5487
Reviewed by: