Issue 6096 - Improve connection timeout error logging #6097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: 389ds#6096 Reviewed by:
jchapma
commented
Feb 15, 2024
ldap/admin/src/logconv.pl
Outdated
| @@ -355,6 +355,7 @@ | |||
| $connmsg{"B4"} = "Server failed to flush data (response) back to Client"; | |||
| $connmsg{"T1"} = "Idle Timeout Exceeded"; | |||
| $connmsg{"T2"} = "IO Block Timeout Exceeded or NTSSL Timeout"; | |||
| $connmsg{"T3"} = "Paged Search Limit Exceeded"; | |||
There was a problem hiding this comment.
I thought it was best to another another T version, for T2 there are already 2 timeout reasons.
There was a problem hiding this comment.
Right good idea. I would replace 'Search Limit' with 'Search Time Limit'
tbordaz
approved these changes
Feb 15, 2024
ldap/admin/src/logconv.pl
Outdated
| @@ -355,6 +355,7 @@ | |||
| $connmsg{"B4"} = "Server failed to flush data (response) back to Client"; | |||
| $connmsg{"T1"} = "Idle Timeout Exceeded"; | |||
| $connmsg{"T2"} = "IO Block Timeout Exceeded or NTSSL Timeout"; | |||
| $connmsg{"T3"} = "Paged Search Limit Exceeded"; | |||
There was a problem hiding this comment.
Right good idea. I would replace 'Search Limit' with 'Search Time Limit'
| @@ -27,6 +27,7 @@ ER2(SLAPD_DISCONNECT_BER_FLUSH, "Server failed to flush response back to Client | |||
| ER2(SLAPD_DISCONNECT_IDLE_TIMEOUT, "Idle Timeout (nsslapd-idletimeout) - T1") | |||
| ER2(SLAPD_DISCONNECT_REVENTS, "Poll revents - R1") | |||
| ER2(SLAPD_DISCONNECT_IO_TIMEOUT, "IO Block Timeout (nsslapd-ioblocktimeout) - T2") | |||
| ER2(SLAPD_DISCONNECT_PAGED_SEARCH_LIMIT, "Paged Search Limit Exceeded - T3") | |||
There was a problem hiding this comment.
'Search Time Limit' would be more precise as there is also size limit that could be confusing
There was a problem hiding this comment.
Thats a good point, I will update
jchapma
added a commit
that referenced
this pull request
Feb 16, 2024
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: #6096 Reviewed by: @tbordaz (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 16, 2024
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: #6096 Reviewed by: @tbordaz (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 16, 2024
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: #6096 Reviewed by: @tbordaz (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 16, 2024
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: #6096 Reviewed by: @tbordaz (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 16, 2024
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: #6096 Reviewed by: @tbordaz (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 16, 2024
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: #6096 Reviewed by: @tbordaz (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 16, 2024
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: #6096 Reviewed by: @tbordaz (Thank you)
jchapma
added a commit
that referenced
this pull request
Feb 21, 2024
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded. Fix description: Correct error message Relates: #6096 Reviewed by: @tbordaz (Thank you)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description: When a paged result search is run with a time limit, if the time limit is exceed the server closes the connection with closed IO timeout (nsslapd-ioblocktimeout) - T2. This error message is incorrect as the reason the connection has been closed was because the specified time limit on a paged result search has been exceeded.
Fix description: Correct error message
Relates: #6096
Reviewed by: