-
Notifications
You must be signed in to change notification settings - Fork 103
Issue 6103 - New connection timeout error breaks errormap #6104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: 389ds#6103 Reviewed by:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good but IMHO you should add a comment in disconnect_error_strings.h to warn that the definition order matters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: #6103 Reviewed by: @droideck. @progier389 (Thank you)
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: #6103 Reviewed by: @droideck. @progier389 (Thank you)
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: #6103 Reviewed by: @droideck. @progier389 (Thank you)
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: #6103 Reviewed by: @droideck. @progier389 (Thank you)
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: #6103 Reviewed by: @droideck. @progier389 (Thank you)
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: #6103 Reviewed by: @droideck. @progier389 (Thank you)
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: #6103 Reviewed by: @droideck. @progier389 (Thank you)
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings. Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list. Relates: #6103 Reviewed by: @droideck. @progier389 (Thank you)
Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings.
Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list.
Relates: #6103
Reviewed by: