Skip to content

Issue 6103 - New connection timeout error breaks errormap #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

jchapma
Copy link
Contributor

@jchapma jchapma commented Feb 20, 2024

Bug description: A recent addition to the connection disconnect error messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by:

Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: 389ds#6103

Reviewed by:
Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good but IMHO you should add a comment in disconnect_error_strings.h to warn that the definition order matters

Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchapma jchapma merged commit d65eea9 into 389ds:main Feb 21, 2024
@jchapma jchapma deleted the errormap branch February 21, 2024 12:43
jchapma added a commit that referenced this pull request Feb 21, 2024
Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by: @droideck. @progier389  (Thank you)
jchapma added a commit that referenced this pull request Feb 21, 2024
Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by: @droideck. @progier389  (Thank you)
jchapma added a commit that referenced this pull request Feb 21, 2024
Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by: @droideck. @progier389  (Thank you)
jchapma added a commit that referenced this pull request Feb 21, 2024
Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by: @droideck. @progier389  (Thank you)
jchapma added a commit that referenced this pull request Feb 21, 2024
Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by: @droideck. @progier389  (Thank you)
jchapma added a commit that referenced this pull request Feb 21, 2024
Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by: @droideck. @progier389  (Thank you)
jchapma added a commit that referenced this pull request Feb 21, 2024
Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by: @droideck. @progier389  (Thank you)
jchapma added a commit that referenced this pull request Feb 21, 2024
Bug description: A recent addition to the connection disconnect error
messaging, conflicts with how errormap.c maps error codes/strings.

Fix description: errormap expects error codes/strings to be in ascending
order. Moved the new error code to the bottom of the list.

Relates: #6103

Reviewed by: @droideck. @progier389  (Thank you)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants