Issue 3527 - Support HAProxy and Instance on the same machine configuration #6107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progier389
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
LGTM:
So instead of checking "ns-slapd connection Client IP" == "HAProxy Header Destination IP" and the address is trusted
The test is now that both
"ns-slapd connection Client IP" is trusted
"HAProxy Header Destination IP" is trusted
That seems good.
BTW in fact this change will also allow configuration having
HAProxy listening on a different subnet than one used to forward the request.
…ration Description: Improve how we handle HAProxy connections to work better when the DS and HAProxy are on the same machine. Ensure the client and header destination IPs are checked against the trusted IP list. Additionally, this change will also allow configuration having HAProxy listening on a different subnet than one used to forward the request. Related: 389ds#3527 Reviewed by: ?
droideck
force-pushed
the
haproxy-locally
branch
from
7e4475c to
195d670
Compare
droideck
added a commit
that referenced
this pull request
Feb 28, 2024
…ration (#6107) Description: Improve how we handle HAProxy connections to work better when the DS and HAProxy are on the same machine. Ensure the client and header destination IPs are checked against the trusted IP list. Additionally, this change will also allow configuration having HAProxy is listening on a different subnet than the one used to forward the request. Related: #3527 Reviewed by: @progier389, @jchapma (Thanks!)
droideck
added a commit
that referenced
this pull request
Feb 28, 2024
…ration (#6107) Description: Improve how we handle HAProxy connections to work better when the DS and HAProxy are on the same machine. Ensure the client and header destination IPs are checked against the trusted IP list. Additionally, this change will also allow configuration having HAProxy is listening on a different subnet than the one used to forward the request. Related: #3527 Reviewed by: @progier389, @jchapma (Thanks!)
droideck
added a commit
that referenced
this pull request
Feb 28, 2024
…ration (#6107) Description: Improve how we handle HAProxy connections to work better when the DS and HAProxy are on the same machine. Ensure the client and header destination IPs are checked against the trusted IP list. Additionally, this change will also allow configuration having HAProxy is listening on a different subnet than the one used to forward the request. Related: #3527 Reviewed by: @progier389, @jchapma (Thanks!)
droideck
added a commit
that referenced
this pull request
Feb 28, 2024
…ration (#6107) Description: Improve how we handle HAProxy connections to work better when the DS and HAProxy are on the same machine. Ensure the client and header destination IPs are checked against the trusted IP list. Additionally, this change will also allow configuration having HAProxy is listening on a different subnet than the one used to forward the request. Related: #3527 Reviewed by: @progier389, @jchapma (Thanks!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 3527 - Support HAProxy and Instance on the same machine configuration
Description: Improve how we handle HAProxy connections to work better when
the DS and HAProxy are on the same machine.
Ensure the client and header destination IPs are checked against the trusted IP list.
Additionally, this change will also allow configuration having
HAProxy listening on a different subnet than one used to forward the request.
Related: #3527
Reviewed by: ?