Skip to content

Address Issue 6117 - Fix the UTC offset print #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

definite
Copy link
Contributor

@definite definite commented Mar 6, 2024

Reference: Bug 2255573 - Timezone America/St_Johns is not properly represented in log timestamps

Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droideck
Copy link
Member

droideck commented Mar 6, 2024

We'll need to rewrite the commit message, though, according to https://www.port389.org/docs/389ds/contributing.html#getting-the-patch-ready

@definite, if possible, please fix it. Otherwise, we'll adjust during the merge process.

Bug Description:

- UTC offset is mistakenly displayed as <sign><hour><seconds>
  -03:30 was displayed as -031800

Fix Description:

- UTC offset is now displayed as <sign><hour><minutes>
  -03.30 is displayed as -0330

Author: Ding-Yi Chen <dchen@redhat.com>
Reviewed by: Simon Pichugin
@definite definite changed the title Address issue #6117 Address Issue 6117 - Fix the UTC offset print Mar 6, 2024
@definite
Copy link
Contributor Author

definite commented Mar 6, 2024

I have changed the commit accordingly. Please take a look.

@droideck droideck merged commit 4eb1cb6 into 389ds:main Mar 7, 2024
droideck pushed a commit that referenced this pull request Mar 7, 2024
Bug Description: UTC offset is mistakenly displayed as <sign><hour><seconds>
-03:30 was displayed as -031800

Fix Description: UTC offset is now displayed as <sign><hour><minutes>
-03.30 is displayed as -0330

Fixes: #6117

Author: Ding-Yi Chen <dchen@redhat.com>

Reviewed by: Simon Pichugin
droideck pushed a commit that referenced this pull request Mar 7, 2024
Bug Description: UTC offset is mistakenly displayed as <sign><hour><seconds>
-03:30 was displayed as -031800

Fix Description: UTC offset is now displayed as <sign><hour><minutes>
-03.30 is displayed as -0330

Fixes: #6117

Author: Ding-Yi Chen <dchen@redhat.com>

Reviewed by: Simon Pichugin
droideck pushed a commit that referenced this pull request Mar 7, 2024
Bug Description: UTC offset is mistakenly displayed as <sign><hour><seconds>
-03:30 was displayed as -031800

Fix Description: UTC offset is now displayed as <sign><hour><minutes>
-03.30 is displayed as -0330

Fixes: #6117

Author: Ding-Yi Chen <dchen@redhat.com>

Reviewed by: Simon Pichugin
droideck pushed a commit that referenced this pull request Mar 7, 2024
Bug Description: UTC offset is mistakenly displayed as <sign><hour><seconds>
-03:30 was displayed as -031800

Fix Description: UTC offset is now displayed as <sign><hour><minutes>
-03.30 is displayed as -0330

Fixes: #6117

Author: Ding-Yi Chen <dchen@redhat.com>

Reviewed by: Simon Pichugin
droideck pushed a commit that referenced this pull request Mar 7, 2024
Bug Description: UTC offset is mistakenly displayed as <sign><hour><seconds>
-03:30 was displayed as -031800

Fix Description: UTC offset is now displayed as <sign><hour><minutes>
-03.30 is displayed as -0330

Fixes: #6117

Author: Ding-Yi Chen <dchen@redhat.com>

Reviewed by: Simon Pichugin
droideck pushed a commit that referenced this pull request Mar 7, 2024
Bug Description: UTC offset is mistakenly displayed as <sign><hour><seconds>
-03:30 was displayed as -031800

Fix Description: UTC offset is now displayed as <sign><hour><minutes>
-03.30 is displayed as -0330

Fixes: #6117

Author: Ding-Yi Chen <dchen@redhat.com>

Reviewed by: Simon Pichugin
droideck pushed a commit that referenced this pull request Mar 7, 2024
Bug Description: UTC offset is mistakenly displayed as <sign><hour><seconds>
-03:30 was displayed as -031800

Fix Description: UTC offset is now displayed as <sign><hour><minutes>
-03.30 is displayed as -0330

Fixes: #6117

Author: Ding-Yi Chen <dchen@redhat.com>

Reviewed by: Simon Pichugin
droideck pushed a commit that referenced this pull request Mar 7, 2024
Bug Description: UTC offset is mistakenly displayed as <sign><hour><seconds>
-03:30 was displayed as -031800

Fix Description: UTC offset is now displayed as <sign><hour><minutes>
-03.30 is displayed as -0330

Fixes: #6117

Author: Ding-Yi Chen <dchen@redhat.com>

Reviewed by: Simon Pichugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants