Issue 6119 - Synchronise accept_thread with slapd_daemon #6120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Description: A corner cases exists, where the slapd_daemon has begun its shutdown process but the accept_thread is still running and capable of handling new connections. When this scenario occurs, the connection subsystem has been partially deallocated and is in an unstable state. A segfault is generated when attempting to get a new connection from the connection table. Fix Description: The connection table is only deallocated when the number of active threads is 0. Modify the accept_thread to adjust the the active thread count during creation/destruction, meaning the connection table can only be freed when the accept_thread has completed Relates: 389ds#6119 Reviewed by:
jchapma
added
the
work in progress
Firstyear
approved these changes
Mar 6, 2024
mreynolds389
reviewed
Mar 6, 2024
ldap/servers/slapd/daemon.c
Outdated
| @@ -1158,6 +1160,8 @@ slapd_daemon(daemon_ports_t *ports) | |||
| slapi_log_err(SLAPI_LOG_EMERG, "slapd_daemon", "Unable to fd accept thread - Shutting Down (" SLAPI_COMPONENT_NAME_NSPR " error %d - %s)\n", | |||
| errorCode, slapd_pr_strerror(errorCode)); | |||
| g_set_shutdown(SLAPI_SHUTDOWN_EXIT); | |||
| } else{ | |||
| g_incr_active_threadcnt(); | |||
|
I will cherry pick back to relevant branches on Monday |
jchapma
added a commit
that referenced
this pull request
Apr 10, 2024
Bug Description: A corner cases exists, where the slapd_daemon has begun its shutdown process but the accept_thread is still running and capable of handling new connections. When this scenario occurs, the connection subsystem has been partially deallocated and is in an unstable state. A segfault is generated when attempting to get a new connection from the connection table. Fix Description: The connection table is only deallocated when the number of active threads is 0. Modify the accept_thread to adjust the the active thread count during creation/destruction, meaning the connection table can only be freed when the accept_thread has completed Relates: #6119 Reviewed by: @tbordaz, @Firstyear , @mreynolds389 (Thank you)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description: A corner cases exists, where the slapd_daemon has begun its shutdown process but the accept_thread is still running and capable of handling new connections. When this scenario occurs, the connection subsystem has been partially deallocated and is in an unstable state. A segfault is generated when attempting to get a new connection from the connection table.
Fix Description: The connection table is only deallocated when the number of active threads is 0. Modify the accept_thread to adjust the the active thread count during creation/destruction, meaning the connection table can only be freed when the accept_thread has completed
Relates: #6119
Reviewed by: