Issue 6057 - vlv search may result wrong result with lmdb - Fix 2 #6121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbordaz
approved these changes
Mar 12, 2024
|
Fixed:
|
progier389
force-pushed
the
i6057_fix2
branch
2 times, most recently
from
cd68b59 to
551d1f2
Compare
|
Fixed: |
progier389
force-pushed
the
i6057_fix2
branch
2 times, most recently
from
9f98987 to
30ba32e
Compare
jchapma
pushed a commit
that referenced
this pull request
Apr 10, 2024
) * Issue 6057 - vlv search may result wrong result with lmdb - Fix 2 * Issue i6057 - Fix2 - Fix review comment Previous fix is failing after a restart because of a chicken and egg issue related to vlv_init and backend initialization. vlv_init requires that the backend get initialized to be able to generate the vlvSearch struct. Because of deadlocks, and to be able to roll back the database instance open transaction I found it easier to avoid using vlv_getindices if vlv is not initialized but rather perform a search on cn=config to build a list of all possible vlv indexes filenames (ignoring the configuration errors) and use that list to open the database files for vlv indices and their cache. Also fixed some minor issues: @droideck minor remarks done about #6091 after the merge a typo while logging info about the database environment parameters Issue: #6057 Reviewed by: @tbordaz, @droideck , @mreynolds389 (Thanks!)
progier389
added a commit
that referenced
this pull request
May 30, 2024
) * Issue 6057 - vlv search may result wrong result with lmdb - Fix 2 * Issue i6057 - Fix2 - Fix review comment Previous fix is failing after a restart because of a chicken and egg issue related to vlv_init and backend initialization. vlv_init requires that the backend get initialized to be able to generate the vlvSearch struct. Because of deadlocks, and to be able to roll back the database instance open transaction I found it easier to avoid using vlv_getindices if vlv is not initialized but rather perform a search on cn=config to build a list of all possible vlv indexes filenames (ignoring the configuration errors) and use that list to open the database files for vlv indices and their cache. Also fixed some minor issues: @droideck minor remarks done about #6091 after the merge a typo while logging info about the database environment parameters Issue: #6057 Reviewed by: @tbordaz, @droideck , @mreynolds389 (Thanks!) (cherry picked from commit e555c2a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix is failing after a restart because of a chicken and egg issue related to vlv_init and backend initialization.
vlv_init requires that the backend get initialized to be able to generate the vlvSearch struct.
Because of deadlocks, and to be able to roll back the database instance open transaction I found it easier to avoid using vlv_getindices if vlv is not initialized but rather perform a search on cn=config to build a list of all possible vlv indexes filenames (ignoring the configuration errors) and use that list to open the database files for vlv indices and their cache.
Also fixed some minor issues:
@droideck minor remarks done about #6091 after the merge
a typo while logging info about the database environment parameters
Issue: #6057
Reviewed by: @tbordaz, @droideck , @mreynolds389 (Thanks!)