Skip to content

Issue 6125 - dscreate interactive fails when chosing mdb backend #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jchapma
Copy link
Contributor

@jchapma jchapma commented Mar 15, 2024

Bug description: dscreate in interactive mode fails when a mdb backend is used. Cast to string missing in the parse_size method.

Fix description: Convert the value to string in parse method.

Fixes: #6125

Reviewed by:

Bug description: dscreate in interactive mode fails when a mdb backend
is used. Cast to string missing in the parse_size method.

Fix description: Convert the value to string in parse method.

Fixes: 389ds#6125

Reviewed by:
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchapma jchapma merged commit d194453 into 389ds:main Mar 19, 2024
@jchapma jchapma deleted the dscreate-mdb branch March 19, 2024 13:32
jchapma added a commit that referenced this pull request Mar 20, 2024
Bug description: dscreate in interactive mode fails when a mdb backend
is used. Cast to string missing in the parse_size method.

Fix description: Convert the value to string in parse method.

Fixes: #6125

Reviewed by: @progier389, @droideck (Thank you)
jchapma added a commit that referenced this pull request Mar 20, 2024
Bug description: dscreate in interactive mode fails when a mdb backend
is used. Cast to string missing in the parse_size method.

Fix description: Convert the value to string in parse method.

Fixes: #6125

Reviewed by: @progier389, @droideck (Thank you)
jchapma added a commit that referenced this pull request Mar 20, 2024
Bug description: dscreate in interactive mode fails when a mdb backend
is used. Cast to string missing in the parse_size method.

Fix description: Convert the value to string in parse method.

Fixes: #6125

Reviewed by: @progier389, @droideck (Thank you)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dscreate interactive fails when chosing mdb backend
3 participants