Issue 6141 - freeipa test_topology_TestCASpecificRUVs is failing #6144
Conversation
| } | ||
| while (rc == 0) { | ||
| cmpres = dbmdb_cmp_dbi_record(mdb_cursor_dbi(cursor->cur), &curpos_key, &curpos_data, &rce->key, &rce->data); | ||
| if (cmpres >= 0) { | ||
| if (cmpres <= 0) { |
There was a problem hiding this comment.
To be honest I read and reread this code several times and still do not understand it.
I understand that rce starts from the beginning of index and count recno up to curpos_key.
I wound assume that rce.key is lower than cursor_key during the loop and that we stop the loop when it gets higher or equal (the previous code).
The new code is working even if I do not understand it ;).
I would appreciate comments or examples in the code to explain the loop.
There was a problem hiding this comment.
I understand that rce starts from the beginning of index and count recno up to curpos_key.
I wound assume that rce.key is lower than cursor_key during the loop and that we stop the loop when it gets higher or equal
You are right up to that point: the loop should go on while cursor_key > rce.key
and should stop it when cursor_key <= rce.key
(the previous code).
That is wrong: cursor_key <= rce.key is cmpres <= 0 (the new code)
( Looks like I am not the only one that inverts the test ! 😉 )
On lmdb, vlv search using a value instead of range may fail (set target on first record instead of smallest record whose key is greater of equal to the wanted value). The reason is that a test is inverted when walking the cursor to find the record position so the loop end after first iteration. Also fix a coverity scan warning Issue: #6141 Reviewed by: @tbordaz
On lmdb, vlv search using a value instead of range may fail (set target on first record instead of smallest record whose key is greater of equal to the wanted value). The reason is that a test is inverted when walking the cursor to find the record position so the loop end after first iteration. Also fix a coverity scan warning Issue: #6141 Reviewed by: @tbordaz (cherry picked from commit 281c027)
On lmdb, vlv search using a value instead of range may fail (set target on first record instead of smallest record whose key is greater of equal to the wanted value).
The reason is that a test is inverted when walking the cursor to find the record position so the loop end after first iteration.
Also fix a coverity scan warning
Issue: #6141
Reviewed by: @tbordaz