Issue 6186 - Change default salt sizes generated in crypt_pwd #6185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonborden
changed the title
progier389
reviewed
May 30, 2024
This commit changes the salt length generated in crypt_pwd from 12 bits to instead match the salt length used by linux shadow: 12bits (2 b64 chars) for CRYPT 48bits (8 b64 chars) for CRYPT-MD5 96bits (16 b64 chars) for CRYPT-SHA256 and CRYPT-SHA512
jasonborden
force-pushed
the
crypt_pwd-salt
branch
from
3bc8f3f to
3a0fc2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #6186 - Increase the amount of salt crypt_pwd generates
Bug Description:
Salt currently generated by crypt_pwd is only 12 bits which is rather weak.
Fix Description:
Makes the salt generated the same length as linux shadow:
12bits (2 b64 chars) for CRYPT
48bits (8 b64 chars) for CRYPT-MD5
96bits (16 b64 chars) for CRYPT-SHA256 and CRYPT-SHA512
relates: https://lists.fedorahosted.org/archives/list/freeipa-users@lists.fedorahosted.org/thread/ZJXVFQ6XC2IEROA2LZNBXKQ6YWAJHAIU/
Author: Jason Borden
Reviewed by: @progier389, @merlinthp (Thanks!)