Issue 6227 - dsconf schema does not show inChain matching rule #6228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progier389
reviewed
Jun 18, 2024
| # Set referral | ||
| log.info("Use dsconf to check defined matching rules") | ||
| log.info(f'Command used: %{dsconf_cmd}') | ||
| proc = subprocess.Popen(dsconf_cmd, stdout=subprocess.PIPE) |
There was a problem hiding this comment.
Hi Thierry,
IMHO you should avoid to use subprocess as far as possible.
In this case you can simply check directly the schema:
schema = Schema(inst)
#mrs = [ str(mr) for mr in schema.get_matchingrules() ]
mrs = [ f"{mr.oid} {mr.names[0]}" for mr in schema.get_matchingrules() if len(mr.names) > 0 ]
print(mrs)
assert '1.2.840.113556.1.4.1941 inchainMatch' in mrs
droideck
approved these changes
Jun 20, 2024
Bug description: The registered inChain MR does defined any matching rule syntax (mr_syntax). When dsconf reads the matching rules (read_schema_dse) it only reports those which have OID and SYNTAX. As a consequence InChain was not reported. Fix description: The syntax defines that assersion syntax that is distinguished name. Add this syntax to the register struct relates: 389ds#6227 Reviewed by: Pierre Rogier (Thanks !)
tbordaz
added a commit
that referenced
this pull request
Jun 24, 2024
Bug description: The registered inChain MR does defined any matching rule syntax (mr_syntax). When dsconf reads the matching rules (read_schema_dse) it only reports those which have OID and SYNTAX. As a consequence InChain was not reported. Fix description: The syntax defines that assersion syntax that is distinguished name. Add this syntax to the register struct relates: #6227 Reviewed by: Pierre Rogier (Thanks !)
tbordaz
added a commit
that referenced
this pull request
Jun 24, 2024
Bug description: The registered inChain MR does defined any matching rule syntax (mr_syntax). When dsconf reads the matching rules (read_schema_dse) it only reports those which have OID and SYNTAX. As a consequence InChain was not reported. Fix description: The syntax defines that assersion syntax that is distinguished name. Add this syntax to the register struct relates: #6227 Reviewed by: Pierre Rogier (Thanks !)
tbordaz
added a commit
that referenced
this pull request
Jun 24, 2024
Bug description: The registered inChain MR does defined any matching rule syntax (mr_syntax). When dsconf reads the matching rules (read_schema_dse) it only reports those which have OID and SYNTAX. As a consequence InChain was not reported. Fix description: The syntax defines that assersion syntax that is distinguished name. Add this syntax to the register struct relates: #6227 Reviewed by: Pierre Rogier (Thanks !)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
The registered inChain MR does defined any matching rule
syntax (mr_syntax).
When dsconf reads the matching rules (read_schema_dse)
it only reports those which have OID and SYNTAX.
As a consequence InChain was not reported.
Fix description:
The syntax defines that assersion syntax that is
distinguished name. Add this syntax to the register
struct
relates: #6227
Reviewed by: