Skip to content

Issue 6233 - CI test wait_for_async_feature_test sometime fails #6234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

progier389
Copy link
Contributor

@progier389 progier389 commented Jun 20, 2024

CI test random failure related to timing.
Fixed by decreasing the minimum number of expected asynchronous results

Issue: #6233

Reviewed by: @droideck, @tbordaz

Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tbordaz
Copy link
Contributor

tbordaz commented Jun 21, 2024

LGTM as well
I was wondering how it works ?
It counts the number of 'waitfor_async_results' message depending on the 'nsds5ReplicaWaitForAsyncResults' tuning. Fine.
Now in 'test_behavior_with_value' it setup a 2 suppliers topology. Enable repl logs then waits 20s to see the final count.
What is the guarantee that the agreement did connect ? Shouldn't it do an dummy update after setting the repl_log ?

@progier389 progier389 merged commit f76503d into 389ds:main Jun 21, 2024
192 of 193 checks passed
@progier389 progier389 deleted the i6233 branch May 20, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants