Issue 6241 - Add support for CRYPT-YESCRYPT #6242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR uses the same defaults parameters as the distros that use yescrypt: 24 b64 salt chars and j9T params. To use yescrypt the system will need libxcrypt 4.2 or higher. |
progier389
reviewed
Jun 28, 2024
Contributor
progier389
left a comment
progier389
left a comment
There was a problem hiding this comment.
Looks good,
but I would prefer that we use #define for the standard crypt algorithm id rather than embedding directly the string in the code.
Maybe a bit picky but this code is sensitive in term of security,
and it is better make it as easily readable as possible ...
/* Standard Crypt Algorithms identifiers (with usual options when needed) */
#define CRYPT_ALGO_ID_SHA512 "$6$"
#define CRYPT_ALGO_ID_YESCRYPT "$y$j9T$"
jasonborden
force-pushed
the
crypt_pwd-yescrypt
branch
from
c42e1dd to
ff86b69
Compare
Description: Implements CRYPT-YESCRYPT as a password storage scheme
jasonborden
force-pushed
the
crypt_pwd-yescrypt
branch
from
ff86b69 to
44108c3
Compare
Contributor
Author
|
Updated with suggested #defined algorithm IDs and comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements CRYPT-YESCRYPT as a password storage scheme
Issue: #6241
Reviewed by: @progier389