Issue 6245 - covscan fixes #6246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreynolds389
reviewed
Jul 1, 2024
| slapi_pblock_set(pb, SLAPI_SEARCH_RESULT_ENTRY, NULL); | ||
| delete_search_result_set(pb, &sr); | ||
| rc = SLAPI_FAIL_GENERAL; | ||
| } |
Contributor
There was a problem hiding this comment.
What coverity issue is this fixing? Just curious :-)
Contributor
Author
There was a problem hiding this comment.
Unreachable code.
There is no break in the while(1) loop but only some "goto bail;"
so the code between the end of the loop and the bail label is unreachable
mreynolds389
reviewed
Jul 1, 2024
mreynolds389
approved these changes
Jul 1, 2024
progier389
force-pushed
the
i5_covscan2024
branch
from
8dd2d72 to
813f70e
Compare
Contributor
Author
|
Fixed the comment typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues reported by coverity scan static analyzer
Issue: #6245
Reviewed by: @mreynolds389 (Thanks!)