Skip to content

Issue 6216 - CI test_fast_slow_import sometime fail #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

progier389
Copy link
Contributor

@progier389 progier389 commented Jul 1, 2024

The test comparing times around 2 seconds is pretty instable.
With this fix, the test is still running, checking that import with private memory works
but does not check any more that it is faster than standard import

Issue: #6216

Reviewed by: @droideck (Thanks!)

Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@progier389 progier389 self-assigned this Jul 3, 2024
@progier389 progier389 merged commit c09717d into 389ds:main Jul 3, 2024
192 of 193 checks passed
@progier389 progier389 deleted the i6216 branch May 20, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants