Skip to content

Issue 6254 - Enabling replication for a sub suffix crashes browser #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

droideck
Copy link
Member

@droideck droideck commented Jul 9, 2024

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too. Set defaults if data is absent.

Fixes: #6254

Reviewed by: ?

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: 389ds#6254

Reviewed by: ?
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droideck droideck merged commit a3d3521 into 389ds:main Jul 10, 2024
192 of 195 checks passed
droideck added a commit that referenced this pull request Jul 10, 2024
…6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: #6254

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jul 10, 2024
…6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: #6254

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jul 10, 2024
…6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: #6254

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jul 10, 2024
…6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: #6254

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jul 10, 2024
…6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: #6254

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jul 10, 2024
…6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: #6254

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jul 10, 2024
…6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: #6254

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jul 10, 2024
…6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: #6254

Reviewed by: @progier389 (Thanks!)
progier389 pushed a commit to progier389/389-ds-base that referenced this pull request Jul 16, 2024
…89ds#6255)

Bug Description: Web Console: Enabling replication for a sub-suffix causes
TypeError: this.props.data.nsds5replicabinddn is not iterable.

Fix Description: Make sure that loadSuffixTree is run for subsuffixes, too.
Set defaults if data is absent.

Fixes: 389ds#6254

Reviewed by: @progier389 (Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - Enabling replication for a sub suffix crashes browser
2 participants